Re: [Qemu-devel] [RESEND PATCH V3] qemu-img info: show nocow info

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 912 bytes --]

On 07/29/2014 01:18 AM, Chunyan Liu wrote:
> Add nocow info in 'qemu-img info' output to show whether the file
> currently has NOCOW flag set or not.
> 
> Signed-off-by: Chunyan Liu <cyliu@suse.com>
> Acked-by: Eric Blake <eblake@redhat.com>

Actually, this should be Reviewed-by, not Acked-by.  My understanding is
that "Reviewed-by" is stronger (I actually read through the patch, and
looked for possible problems) while "Acked-by" is weaker (a maintainer
stating that the work is taken in on the basis of third-party reviews
without actually reviewing the patch itself).

> ---
> Resend for QEMU 2.2. Change json version comment.
> 
>  block/qapi.c         | 25 +++++++++++++++++++++++++
>  qapi/block-core.json |  5 ++++-
>  2 files changed, 29 insertions(+), 1 deletion(-)
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]