From: m.szyprowski@samsung.com (Marek Szyprowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 RESEND 2/4] drivers: of: initialize and assign reserved memory to newly created devices
Date: Tue, 29 Jul 2014 16:47:04 +0200 [thread overview]
Message-ID: <53D7B3E8.6070906@samsung.com> (raw)
In-Reply-To: <20140728141700.55FC4C408EA@trevor.secretlab.ca>
Hello,
On 2014-07-28 16:17, Grant Likely wrote:
> On Mon, 14 Jul 2014 10:28:05 +0200, Marek Szyprowski <m.szyprowski@samsung.com> wrote:
>> Use recently introduced of_reserved_mem_device_init() function to
>> automatically assign respective reserved memory region to the newly created
>> platform and amba device.
>>
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> I'm still not okay with this patch. I don't think it is appropriate to
> add the hook into the generic path that gets used for every platform
> device. The devices that need reserved memory should explicitly request
> it, and any setup be done at that time.
Okay... I thought that it will be easier to have it done in generic
code, if You don't
think so, then I give up and we will add it in all drivers requiring
such memory regions.
What about patch 3/4 and 4/4? Would it be possible to have your ack to
get them merged?
Right now patch 4/4 depends on changes from akpm tree, so it will be
best to merge them
to akpm tree.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
WARNING: multiple messages have this Message-ID (diff)
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Grant Likely <grant.likely@linaro.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: linaro-mm-sig@lists.linaro.org, devicetree@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>,
Michal Nazarewicz <mina86@mina86.com>,
Tomasz Figa <t.figa@samsung.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Laura Abbott <lauraa@codeaurora.org>,
Nishanth Peethambaran <nishanth.p@gmail.com>,
Marc <marc.ceeeee@gmail.com>,
Josh Cartwright <joshc@codeaurora.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Paul Mackerras <paulus@samba.org>, Jon Medhurst <tixy@linaro.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
"Aneesh Kumar K.V." <aneesh.kumar@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 RESEND 2/4] drivers: of: initialize and assign reserved memory to newly created devices
Date: Tue, 29 Jul 2014 16:47:04 +0200 [thread overview]
Message-ID: <53D7B3E8.6070906@samsung.com> (raw)
In-Reply-To: <20140728141700.55FC4C408EA@trevor.secretlab.ca>
Hello,
On 2014-07-28 16:17, Grant Likely wrote:
> On Mon, 14 Jul 2014 10:28:05 +0200, Marek Szyprowski <m.szyprowski@samsung.com> wrote:
>> Use recently introduced of_reserved_mem_device_init() function to
>> automatically assign respective reserved memory region to the newly created
>> platform and amba device.
>>
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> I'm still not okay with this patch. I don't think it is appropriate to
> add the hook into the generic path that gets used for every platform
> device. The devices that need reserved memory should explicitly request
> it, and any setup be done at that time.
Okay... I thought that it will be easier to have it done in generic
code, if You don't
think so, then I give up and we will add it in all drivers requiring
such memory regions.
What about patch 3/4 and 4/4? Would it be possible to have your ack to
get them merged?
Right now patch 4/4 depends on changes from akpm tree, so it will be
best to merge them
to akpm tree.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2014-07-29 14:47 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 8:28 [PATCH v2 RESEND 0/4] CMA & device tree, once again Marek Szyprowski
2014-07-14 8:28 ` Marek Szyprowski
2014-07-14 8:28 ` Marek Szyprowski
2014-07-14 8:28 ` [PATCH v2 RESEND 1/4] drivers: of: add automated assignment of reserved regions to client devices Marek Szyprowski
2014-07-14 8:28 ` Marek Szyprowski
2014-07-14 8:28 ` Marek Szyprowski
2014-07-28 14:15 ` Grant Likely
2014-07-28 14:15 ` Grant Likely
2014-07-28 14:15 ` Grant Likely
2014-07-14 8:28 ` [PATCH v2 RESEND 2/4] drivers: of: initialize and assign reserved memory to newly created devices Marek Szyprowski
2014-07-14 8:28 ` Marek Szyprowski
2014-07-14 8:28 ` Marek Szyprowski
2014-07-28 14:17 ` Grant Likely
2014-07-28 14:17 ` Grant Likely
2014-07-28 14:17 ` Grant Likely
2014-07-29 14:47 ` Marek Szyprowski [this message]
2014-07-29 14:47 ` Marek Szyprowski
2014-07-29 19:46 ` Grant Likely
2014-07-29 19:46 ` Grant Likely
2014-07-14 8:28 ` [PATCH v2 RESEND 3/4] drivers: dma-coherent: add initialization from device tree Marek Szyprowski
2014-07-14 8:28 ` Marek Szyprowski
2014-07-14 8:28 ` Marek Szyprowski
2014-07-29 21:54 ` Grant Likely
2014-07-29 21:54 ` Grant Likely
2014-07-29 21:54 ` Grant Likely
2014-07-30 5:33 ` Marek Szyprowski
2014-07-30 5:33 ` Marek Szyprowski
2014-07-30 23:49 ` Grant Likely
2014-07-30 23:49 ` Grant Likely
2014-07-30 23:49 ` Grant Likely
2014-07-31 5:15 ` Marek Szyprowski
2014-07-31 5:15 ` Marek Szyprowski
2014-07-31 5:15 ` Marek Szyprowski
2014-07-14 8:28 ` [PATCH v2 RESEND 4/4] drivers: dma-contiguous: " Marek Szyprowski
2014-07-14 8:28 ` Marek Szyprowski
2014-07-14 8:28 ` Marek Szyprowski
2014-07-29 21:58 ` Grant Likely
2014-07-29 21:58 ` Grant Likely
2014-07-29 21:58 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D7B3E8.6070906@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.