From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH v8 00/19] x86/PMU: Xen PMU PV(H) support Date: Tue, 29 Jul 2014 11:00:26 -0400 Message-ID: <53D7B70A.2090702@oracle.com> References: <1404225480-2664-1-git-send-email-boris.ostrovsky@oracle.com> <53D7726D020000780002728F@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53D7726D020000780002728F@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: kevin.tian@intel.com, keir@xen.org, suravee.suthikulpanit@amd.com, andrew.cooper3@citrix.com, tim@xen.org, dietmar.hahn@ts.fujitsu.com, xen-devel@lists.xen.org, David Vrabel , jun.nakajima@intel.com List-Id: xen-devel@lists.xenproject.org On 07/29/2014 04:07 AM, Jan Beulich wrote: >>>> On 01.07.14 at 16:37, wrote: >> Changes in v8: >> >> * Cleaned up a bit definitions of struct xenpf_symdata and xen_pmu_params >> * Added compat checks for vpmu structures >> * Converted vpmu flag manipulation macros to inline routines >> * Reimplemented vpmu_unload_all() to avoid long loops >> * Reworked PMU fault generation and handling (new patch #12) >> * Added checks for domain->vcpu[] non-NULLness >> * Added more comments, renamed some routines and macros, code style cleanup > Having gone through this series once more (with often just minor > comments), I'd say the series could go in once those comments > got addressed. Great! There will be one more bug fix in the next revision. I need to swap the order of 'context_saved(prev)' and 'vpmu_load(next)' in context_switch() because I need prev->is_running to be clear. > But since I didn't follow the discussion of the Linux > side patches, interface-wise it wouldn't make sense if there were > objections in that area there. Could you please summarize the > status of the review process there? The kernel part is being reviewed and the comments so far (mostly from David) were not related to interfaces. I will post the new version soon. The tool part (perf) has not been posted yet but it has no dependence on interfaces. -boris