From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59975)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1XCA8I-0003ep-9F
	for qemu-devel@nongnu.org; Tue, 29 Jul 2014 12:20:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1XCA8C-0007MX-Gp
	for qemu-devel@nongnu.org; Tue, 29 Jul 2014 12:20:10 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59870)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1XCA8C-0007Lb-8m
	for qemu-devel@nongnu.org; Tue, 29 Jul 2014 12:20:04 -0400
Message-ID: <53D7B98F.5070303@redhat.com>
Date: Tue, 29 Jul 2014 09:11:11 -0600
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <1406637686-25762-1-git-send-email-stefanha@redhat.com>
	<1406637686-25762-3-git-send-email-stefanha@redhat.com>
In-Reply-To: <1406637686-25762-3-git-send-email-stefanha@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="AhOnk7gvAIex2WTCrcgnpknCsxcbxC7rF"
Subject: Re: [Qemu-devel] [PATCH 2/2] qemu-iotests: add multiwrite test cases
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, andrey@xdel.ru, sviatoslav.pestov@gmail.com

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--AhOnk7gvAIex2WTCrcgnpknCsxcbxC7rF
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 07/29/2014 06:41 AM, Stefan Hajnoczi wrote:
> This test case covers the basic bdrv_aio_multiwrite() scenarios:
> 1. Single request
> 2. Sequential requests
> 3. Overlapping requests
> 4. Disjoint requests
>=20
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---

> +echo
> +echo "=3D=3D Overlapping requests =3D=3D"
> +_make_test_img $size
> +$QEMU_IO -c "multiwrite 0 4k ; 1k 2k" "$TEST_IMG" | _filter_qemu_io
> +

This only tests superset overlap:

AAAA
 BB

Wouldn't it be good to also test head overlap, tail overlap, and subset
overlap, as in:

AAA
  BB

 AAA
BB

 AA
BBBB


--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--AhOnk7gvAIex2WTCrcgnpknCsxcbxC7rF
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg

iQEcBAEBCAAGBQJT17mPAAoJEKeha0olJ0NqkOYH/06rjIBAZZEjSwlzl7v3+crg
n4vCAgAuGDLyGyKl7L91nXh5/M6XkokYqNBI93JevUYVV8p4xqbVtc/ov94byBgg
mqRAUv7DRxOQBQDAsFWbsnvKMFQHXjNbVahFoGrXk3XrIUepTTjAoP1VQ+r2Uo56
ltdyczpHXkwSn/EcVwmVKC2xv+POD7BdA3N9gTHfLccQk2CytSO4uIh68arrGiGk
A2bwEijeOaQ8NyE261UvhMHE7Gj4VuRgZuDvWEntMgGtKTVxWWETtAD03YO7KFUj
opN8xPq1LvvL/AdCLulFQNh2FJZcmnMXAOg4gLF4OEW4Oe/y/wJz6hdVTfb/GUk=
=xH0+
-----END PGP SIGNATURE-----

--AhOnk7gvAIex2WTCrcgnpknCsxcbxC7rF--