Re: [Qemu-devel] [PATCH RFC v2 07/12] VMState test: qmp interface for querying the vmstate testing process

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 933 bytes --]

On 07/29/2014 09:17 AM, Eric Blake wrote:
> On 07/25/2014 09:39 AM, Sanidhya Kashyap wrote:
>> This patch provides the information about an already executing testing
>> process. I have modified the qmp command to query-test-vmstates from
>> test-vmstates-get-info.

This last sentence does not belong in the commit message proper, rather,
move it...

>>
>> Signed-off-by: Sanidhya Kashyap <sanidhya.iiith@gmail.com>
>> ---

...here, as a changelog for how the v2 differs from v1.  Years from now,
when someone is reading qemu.git, they won't care what alternative names
were proposed, only what is actually committed.

> 
>> +++ b/qmp-commands.hx
> 
>> +SQMP
>> +query-test-vmstates-info
>> +------------------------

s/-info//, to match the actual command name that you documented in the
.json.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]