From: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: nfont@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org,
paulus@samba.org
Subject: Re: [PATCH] powerpc/pci: reorder pci bus/bridge unregistration during PHB removal
Date: Tue, 29 Jul 2014 10:54:47 -0700 [thread overview]
Message-ID: <53D7DFE7.8000304@linux.vnet.ibm.com> (raw)
In-Reply-To: <1406598256.11977.1.camel@concordia>
On 07/28/2014 06:44 PM, Michael Ellerman wrote:
> On Mon, 2014-07-28 at 20:48 -0400, Tyrel Datwyler wrote:
>> Commit bcdde7e made __sysfs_remove_dir() recursive and introduced a BUG_ON
>> during PHB removal while attempting to delete the power managment attribute
>> group of the bus. This is a result of tearing the bridge and bus devices down
>> out of order in remove_phb_dynamic. Since, the the bus resides below the bridge
>> in the sysfs device tree it should be torn down first.
>>
>> This patch simply moves the device_unregister call for the PHB bridge device
>> after the device_unregister call for the PHB bus.
>>
>> Signed-off-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
>
> That commit went into 3.13, so shouldn't this be CC to stable?
Darn it. Yes, it should.
>
> And also:
>
> Fixes: bcdde7e221a8 ("sysfs: make __sysfs_remove_dir() recursive")
>
> cheers
>
>
next prev parent reply other threads:[~2014-07-29 17:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 0:48 [PATCH] powerpc/pci: reorder pci bus/bridge unregistration during PHB removal Tyrel Datwyler
2014-07-29 1:44 ` Michael Ellerman
2014-07-29 17:54 ` Tyrel Datwyler [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-07-29 17:48 Tyrel Datwyler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D7DFE7.8000304@linux.vnet.ibm.com \
--to=tyreld@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=nfont@linux.vnet.ibm.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.