From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43252)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XCD1e-0003eG-9G
	for qemu-devel@nongnu.org; Tue, 29 Jul 2014 15:25:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XCD1S-0003gE-VM
	for qemu-devel@nongnu.org; Tue, 29 Jul 2014 15:25:30 -0400
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <53D7F518.4020603@twiddle.net>
Date: Tue, 29 Jul 2014 09:25:12 -1000
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1406301817-20766-1-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1406301817-20766-1-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] hw/arm/boot: Set PC correctly when loading
 AArch64 ELF files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Christopher Covington <cov@codeaurora.org>, qemu-stable@nongnu.org

On 07/25/2014 05:23 AM, Peter Maydell wrote:
> +                env->regs[15] = info->entry & 0xfffffffe;

You'd do well to use a U suffix here, otherwise c89 makes this -2 while c99
does what you want.  Which makes a tiny difference on a 64-bit host.


r~