All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anil Shashikumar Belur <askb23@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	Tobias Klauser <tklauser@distanz.ch>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
	silvio.fricke@gmail.com, linux-kernel@vger.kernel.org,
	bjorn@mork.no
Subject: Re: [PATCH 1/1] drivers: staging: vt6655: ioctl.c - missing __user annotation
Date: Wed, 30 Jul 2014 08:04:11 +0530	[thread overview]
Message-ID: <53D859A3.1010607@gmail.com> (raw)
In-Reply-To: <20140729091751.GB4856@mwanda>


On Tuesday 29 July 2014 02:47 PM, Dan Carpenter wrote:
> On Tue, Jul 29, 2014 at 10:05:38AM +0200, Tobias Klauser wrote:
>
>> Wouldn't it be better to annotate the data member in struct tagSCmdRequest
>> with __user instead of introducing all these casts?

Hi,

Yes, having the data member annotated as '__user' in 'struct
tagSCmdRequest' looks like a much cleaner way for fixing these warnings.
I will re-work on this patch this patch and submit again.

Thanks,
Anil

      reply	other threads:[~2014-07-30  2:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-28  7:58 [PATCH 1/1] drivers: staging: vt6655: ioctl.c - missing __user annotation Anil Belur
2014-07-29  8:05 ` Tobias Klauser
2014-07-29  9:17   ` Dan Carpenter
2014-07-30  2:34     ` Anil Shashikumar Belur [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D859A3.1010607@gmail.com \
    --to=askb23@gmail.com \
    --cc=bjorn@mork.no \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=silvio.fricke@gmail.com \
    --cc=tklauser@distanz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.