All of lore.kernel.org
 help / color / mirror / Atom feed
From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
To: <dsterba@suse.cz>,
	"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 1/2] btrfs-progs: introduce test_issubvolname() for simplicity
Date: Wed, 30 Jul 2014 11:58:37 +0900	[thread overview]
Message-ID: <53D85F5D.40301@jp.fujitsu.com> (raw)
In-Reply-To: <20140729133208.GS1553@twin.jikos.cz>

Hi David,

(2014/07/29 22:32), David Sterba wrote:
> On Fri, Jul 25, 2014 at 03:16:58PM +0900, Satoru Takeuchi wrote:
>> From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
>>
>> There are many duplicated codes to check if the given string is
>> correct subvolume name. Introduce test_issubvolname() for this
>> purpose for simplicity.
>
> Please move it to utils.c

OK, I'll do. In addition, how about moving test_isdir() and
test_issubvolume() to utils.c too? These are also utility functions.

Thanks,
Satoru

> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


  reply	other threads:[~2014-07-30  2:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-25  6:16 [PATCH 1/2] btrfs-progs: introduce test_issubvolname() for simplicity Satoru Takeuchi
2014-07-29 13:32 ` David Sterba
2014-07-30  2:58   ` Satoru Takeuchi [this message]
2014-07-30 15:54     ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D85F5D.40301@jp.fujitsu.com \
    --to=takeuchi_satoru@jp.fujitsu.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.