From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?windows-1252?Q?Michel_D=E4nzer?= <michel@daenzer.net>
Subject: Re: [PATCH] drm/radeon: tweak ACCEL_WORKING2 query for hawaii
Date: Wed, 30 Jul 2014 12:26:56 +0900
Message-ID: <53D86600.2050902@daenzer.net>
References: <1406644398-2191-1-git-send-email-alexander.deucher@amd.com>
 <20140729153913.GA3103@gmail.com>
 <CADnq5_Oxsv=nFDNS1j=1LdO4OTTuv7p2bvGePL1EiJ-X8Q+ZKA@mail.gmail.com>
 <20140729171005.GB3103@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail.gna.ch (darkcity.gna.ch [195.226.6.51])
 by gabe.freedesktop.org (Postfix) with ESMTP id 708D089F0B
 for <dri-devel@lists.freedesktop.org>; Tue, 29 Jul 2014 20:27:01 -0700 (PDT)
In-Reply-To: <20140729171005.GB3103@gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Jerome Glisse <j.glisse@gmail.com>, Alex Deucher <alexdeucher@gmail.com>
Cc: Maling list - DRI developers <dri-devel@lists.freedesktop.org>
List-Id: dri-devel@lists.freedesktop.org

On 30.07.2014 02:10, Jerome Glisse wrote:
> On Tue, Jul 29, 2014 at 01:05:15PM -0400, Alex Deucher wrote:
>> On Tue, Jul 29, 2014 at 11:39 AM, Jerome Glisse <j.glisse@gmail.com> wro=
te:
>>> On Tue, Jul 29, 2014 at 10:33:18AM -0400, Alex Deucher wrote:
>>>> Return 2 so we can be sure the kernel has the necessary
>>>> changes for acceleration to work.
>>>
>>> I highly dislike that ? Why about just using nop2 in userspace ?
>>
>> How to we tell whether the version of mesa has that change or not?
> =

> You do not need to know that in kernel, all that is needed is for userspa=
ce
> to test 3.16 kernel as it's all that is needed to get accel working.

What if the Hawaii fixes are backported to older kernels?


> So i would say enable accel on ddx now because truly if someone update it=
s ddx
> then it must have updated mesa too.

There is no such guarantee.


This looks like a pretty good solution to me. Please add a check for
this in the Gallium winsys code as well for the benefit of non-X apps
such as Wayland compositors.


-- =

Earthling Michel D=E4nzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer