Re: [PATCH][meta-python] python-slip-dbus: add recipe

[Rongqing Li <rongqing.li@windriver.com>]

On 07/30/2014 02:49 PM, Khem Raj wrote:
> On Tue, Jul 29, 2014 at 11:10 PM,  <rongqing.li@windriver.com> wrote:
>> +SECTION = "devel/python"
>> +LICENSE = "GPLv2+"
>> +LIC_FILES_CHKSUM = "file://COPYING;md5=5574c6965ae5f583e55880e397fbb018"
>> +SRCNAME = "python-slip"
>> +
>> +SRC_URI = "https://fedorahosted.org/released/python-slip/python-slip-${PV}.tar.bz2"
>
> You could use SRCNAME in SRC_URI as well instead of hardcoding python-slip
>
>> +S = "${WORKDIR}/${SRCNAME}-${PV}"
>> +
>> +inherit setuptools
>> +
>> +SRC_URI[md5sum] = "fb3299d75af1a67ca6679d96ce839da6"
>> +SRC_URI[sha256sum] = "f47361ec52b608309b83c71905e692b6b363eaf3b8a7afdeff866cd94463ad5c"
>> +
>> +do_compile_prepend() {
>> +    sed -e 's/@VERSION@/0.6.0/g' setup.py.in > setup.py
>
> could this somehow use PV and not 0.6.0 hardcoded ?
>
>> +}
>
> may be also run the recipe thru contrib/oe-stylize.py for formatting
> and structure.
>

Thanks, I will change them

-- 
Best Reagrds,
Roy | RongQing Li