From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id AED36E006F1; Wed, 30 Jul 2014 00:36:13 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high * trust * [192.55.52.93 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 1DAD1E003FA for ; Wed, 30 Jul 2014 00:36:09 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 30 Jul 2014 00:35:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,762,1400050800"; d="scan'208";a="577538590" Received: from mmckenna-mobl2.ger.corp.intel.com (HELO [10.255.12.249]) ([10.255.12.249]) by fmsmga002.fm.intel.com with ESMTP; 30 Jul 2014 00:34:55 -0700 Message-ID: <53D8A01F.9020305@linux.intel.com> Date: Wed, 30 Jul 2014 00:34:55 -0700 From: Saul Wold User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Patrice B , poky@yoctoproject.org References: <1406699656.22364.4.camel@localhost.localdomain> In-Reply-To: <1406699656.22364.4.camel@localhost.localdomain> Subject: Re: [PATCH 1/1] Add patch 0001-Typo-in-fuser-makes-M-on-all-the-time.patch X-BeenThere: poky@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Poky build system developer discussion & patch submission for meta-yocto List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jul 2014 07:36:13 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit This patch should be sent to openembedded-core@ On 07/29/2014 10:54 PM, Patrice B wrote: > This patch fixes a major bug in fuser that makes it behave as if -M > option is always used ( http://bugs.debian.org/740275 ). Hoping the > patches is correctly done... > > Signed-off-by: Patrice Bouchand > > --- > ...001-Typo-in-fuser-makes-M-on-all-the-time.patch | 44 ++++++++++++++++++++++ > meta/recipes-extended/psmisc/psmisc_22.21.bb | 2 + > 2 files changed, 46 insertions(+) > create mode 100644 meta/recipes-extended/psmisc/files/0001-Typo-in-fuser-makes-M-on-all-the-time.patch > > diff --git a/meta/recipes-extended/psmisc/files/0001-Typo-in-fuser-makes-M-on-all-the-time.patch b/meta/recipes-extended/psmisc/files/0001-Typo-in-fuser-makes-M-on-all-the-time.patch > new file mode 100644 > index 0000000..3a4c9a9 > --- /dev/null > +++ b/meta/recipes-extended/psmisc/files/0001-Typo-in-fuser-makes-M-on-all-the-time.patch > @@ -0,0 +1,44 @@ > +From 3638cc55b4d08851faba46635d737b24d016665b Mon Sep 17 00:00:00 2001 > +From: Brad Jorsch > +Date: Fri, 28 Feb 2014 21:55:02 +1100 > +Subject: [PATCH] Typo in fuser makes -M on all the time > + > +Brad found that fuser had the -M option on all the time. > +A simple but significant typo caused this, thanks the the patch. > + > +Bug-Debian: http://bugs.debian.org/740275 > + > +Signed-off-by: Craig Small This needs an Upstream-Status: Backport? > +--- > + ChangeLog | 4 ++++ > + src/fuser.c | 2 +- > + 2 files changed, 5 insertions(+), 1 deletion(-) > + > +diff --git a/ChangeLog b/ChangeLog > +index fd1cccf..e5f784c 100644 > +--- a/ChangeLog > ++++ b/ChangeLog > +@@ -1,3 +1,7 @@ > ++Changes in 22.22 > ++================ > ++ * Fixed typo in fuser which has -M on Debian #740275 > ++ > + Changes in 22.21 > + ================ > + * Missing comma in fuser(1) added Debian #702391 > +diff --git a/src/fuser.c b/src/fuser.c > +index b485f65..389b302 100644 > +--- a/src/fuser.c > ++++ b/src/fuser.c > +@@ -1174,7 +1174,7 @@ int main(int argc, char *argv[]) > + usage(_("No process specification given")); > + > + /* Check if -M flag was used and if so check mounts */ > +- if (opts * OPT_ISMOUNTPOINT) { > ++ if (opts & OPT_ISMOUNTPOINT) { > + check_mountpoints(&mounts, &names_head, &names_tail); > + } > + > +-- > +1.8.4.2 > + > diff --git a/meta/recipes-extended/psmisc/psmisc_22.21.bb b/meta/recipes-extended/psmisc/psmisc_22.21.bb > index 22f65c5..9f328bb 100644 > --- a/meta/recipes-extended/psmisc/psmisc_22.21.bb > +++ b/meta/recipes-extended/psmisc/psmisc_22.21.bb > @@ -4,3 +4,5 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3" > > SRC_URI[md5sum] = "935c0fd6eb208288262b385fa656f1bf" > SRC_URI[sha256sum] = "97323cad619210845b696d7d722c383852b2acb5c49b5b0852c4f29c77a8145a" > + > +SRC_URI += "file://0001-Typo-in-fuser-makes-M-on-all-the-time.patch" >