From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hongyang Yang <yanghy@cn.fujitsu.com>
Subject: Re: [PATCH v18 02/11] libxl: add support for async.
 function calls when using libxl__ao_device
Date: Wed, 30 Jul 2014 16:45:19 +0800
Message-ID: <53D8B09F.1090203@cn.fujitsu.com>
References: <1406539445-12708-1-git-send-email-yanghy@cn.fujitsu.com>	<1406539445-12708-3-git-send-email-yanghy@cn.fujitsu.com>
	<21463.55527.752884.372747@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21463.55527.752884.372747@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: laijs@cn.fujitsu.com, wency@cn.fujitsu.com, andrew.cooper3@citrix.com, yunhong.jiang@intel.com, eddie.dong@intel.com, xen-devel@lists.xen.org, rshriram@cs.ubc.ca, ian.campbell@citrix.com
List-Id: xen-devel@lists.xenproject.org

On 07/30/2014 01:24 AM, Ian Jackson wrote:
> Yang Hongyang writes ("[PATCH v18 02/11] libxl: add support for async. function calls when using libxl__ao_device"):
>> Extend libxl__ao_device with a libxl__ev_child member, which can be
>> used to asynchronously execute functions that take a long time to complete.
>
> The code change is fine.
>
> I think the commit message and the comment should explain that this
> member is used only for syscalls where only a synchronous version is
> provided.
>
> How about
>
>   Extend libxl__ao_device with a libxl__ev_child member.
>
>   This can be used to fork children to allow the asynchronous execution
>   of system calls which only come in a synchronous variant.  This will
>   be useful for Remus, in the following patches.
>
> instead ?
>
>> +    /* for executing functions asynchronously */
>> +    libxl__ev_child child;
>
> And
>    +    /* for asynchronous execution of synchronous-only syscalls etc. */

It is better, thank you!

>
> Thanks,
> Ian.
> .
>

-- 
Thanks,
Yang.