From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH] drm: omapdrm: fix compiler errors Date: Wed, 30 Jul 2014 14:08:05 +0300 Message-ID: <53D8D215.5050402@ti.com> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0930535723==" Return-path: Received: from devils.ext.ti.com (devils.ext.ti.com [198.47.26.153]) by gabe.freedesktop.org (Postfix) with ESMTP id 1F2AA6E5D1 for ; Wed, 30 Jul 2014 04:08:18 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Russell King , David Airlie Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0930535723== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rcgcSSCkiamqg6gqRD4Mj2PhQpCGBwoVH" --rcgcSSCkiamqg6gqRD4Mj2PhQpCGBwoVH Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Hi Dave, On 12/07/14 12:53, Russell King wrote: > Regular randconfig nightly testing has detected problems with omapdrm. >=20 > omapdrm fails to build when the kernel is built to support 64-bit DMA > addresses and/or 64-bit physical addresses due to an assumption about > the width of these types. >=20 > Use %pad to print DMA addresses, rather than %x or %Zx (which is even > more wrong than %x). Avoid passing a uint32_t pointer into a function > which expects dma_addr_t pointer. >=20 > drivers/gpu/drm/omapdrm/omap_plane.c: In function 'omap_plane_pre_apply= ': > drivers/gpu/drm/omapdrm/omap_plane.c:145:2: error: format '%x' expects = argument of type 'unsigned int', but argument 5 has type 'dma_addr_t' [-W= error=3Dformat] > drivers/gpu/drm/omapdrm/omap_plane.c:145:2: error: format '%x' expects = argument of type 'unsigned int', but argument 6 has type 'dma_addr_t' [-W= error=3Dformat] > make[5]: *** [drivers/gpu/drm/omapdrm/omap_plane.o] Error 1 > drivers/gpu/drm/omapdrm/omap_gem.c: In function 'omap_gem_get_paddr': > drivers/gpu/drm/omapdrm/omap_gem.c:794:4: error: format '%x' expects ar= gument of type 'unsigned int', but argument 3 has type 'dma_addr_t' [-Wer= ror=3Dformat] > drivers/gpu/drm/omapdrm/omap_gem.c: In function 'omap_gem_describe': > drivers/gpu/drm/omapdrm/omap_gem.c:991:4: error: format '%Zx' expects a= rgument of type 'size_t', but argument 7 has type 'dma_addr_t' [-Werror=3D= format] > drivers/gpu/drm/omapdrm/omap_gem.c: In function 'omap_gem_init': > drivers/gpu/drm/omapdrm/omap_gem.c:1470:4: error: format '%x' expects a= rgument of type 'unsigned int', but argument 7 has type 'dma_addr_t' [-We= rror=3Dformat] > make[5]: *** [drivers/gpu/drm/omapdrm/omap_gem.o] Error 1 > drivers/gpu/drm/omapdrm/omap_dmm_tiler.c: In function 'dmm_txn_append':= > drivers/gpu/drm/omapdrm/omap_dmm_tiler.c:226:2: error: passing argument= 3 of 'alloc_dma' from incompatible pointer type [-Werror] > make[5]: *** [drivers/gpu/drm/omapdrm/omap_dmm_tiler.o] Error 1 > make[5]: Target `__build' not remade because of errors. > make[4]: *** [drivers/gpu/drm/omapdrm] Error 2 >=20 > Signed-off-by: Russell King Acked-by: Tomi Valkeinen Dave, I don't have any other patches for omapdrm for 3.17, so can you apply this directly? Tomi --rcgcSSCkiamqg6gqRD4Mj2PhQpCGBwoVH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJT2NIVAAoJEPo9qoy8lh71/YwP/jF0hckKOXa8jourdNZt8kFu XGZ78snQW7b7SHTxzKIip3fyEVESDKtIMW2OzGUCH55ca0LV8kXB+l5PYxYfWZ/H OnSo6fqECWXzJE8qXxsfNo1u86KouaAdLh9wfAU2PB2eUHik0xnZN+7b6szoADKc 95h7GOSjatgRNCYP8ucaBYc93JyqtF46rfpCxkIEr7JCpDn2Ch+vJjNZWPjwJpUV +UE+L41etKUfKuzep2/rASP81XIht5COU8ho1Tv0vI1skV9SaV9RwVlKActkv+Zl 6EBN7IXne2aGvG9ny/WuiY5BM/iGgvo1oJSNRBNkeXaTirMtfw8BodiwB5WOLWuj WhQKoxIXXLJgYl+660esFNgi//wiLz9T6u5HajXJZXhKJzfsGaAjjRqsHZJqwhFO 1GYF+mrFILui9S5p+w58yVGJ1wDFi9/V/lYsCy3gZobozZ3TbJ4WrhF0eJUsf6Ce p3+yDGLmug9ec9s5y6MpiT3FVkWSPDWiiSXkToYz26z6OWwjv3BrjLkLuZ9EUB57 tXLClPPk9OW3AUEx+fc5PGhR75lX1gaSDvhwJ5H+DmdNSlqles4gH7vidyuQQ8xY OANy07jgriONkKATct4eROvs2GqLoxmnoC0WQqs04s25nqVEYSUL5dGOZJxs6lYz /cS/1qCyjtFLYlHcLpNr =mI5F -----END PGP SIGNATURE----- --rcgcSSCkiamqg6gqRD4Mj2PhQpCGBwoVH-- --===============0930535723== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0930535723==--