All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/2] Kbuild: Add a option to enable dwarf4
Date: Wed, 30 Jul 2014 15:38:24 +0200	[thread overview]
Message-ID: <53D8F550.2070800@suse.cz> (raw)
In-Reply-To: <1406675493-2539-2-git-send-email-andi@firstfloor.org>

On 2014-07-30 01:11, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
> 
> I found that a lot of unresolvable variables when using gdb on the kernel
> become resolvable when dwarf4 is enabled. So add a Kconfig flag to enable it.
> 
> It definitely increases the debug information size, but on the other
> hand this isn't so bad when debug fusion is used.
> 
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
>  Makefile          | 3 +++
>  lib/Kconfig.debug | 9 +++++++++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index 6a717cd..6cdf3f0 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -696,6 +696,9 @@ KBUILD_CFLAGS	+= -g
>  endif
>  KBUILD_AFLAGS	+= -Wa,-gdwarf-2
>  endif
> +ifdef CONFIG_DEBUG_INFO_DWARF4
> +KBUILD_CFLAGS	+= -gdwarf-4
> +endif

Make it $(call cc-option,-gdwarf-4), so as not to break allmodconfig
with older GCCs. Otherwise the patch is OK.

Michal

  reply	other threads:[~2014-07-30 13:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-29 23:11 [PATCH 1/2] kbuild: Support split debug info v4 Andi Kleen
2014-07-29 23:11 ` [PATCH 2/2] Kbuild: Add a option to enable dwarf4 Andi Kleen
2014-07-30 13:38   ` Michal Marek [this message]
2014-07-30 13:50 ` [PATCH 1/2] kbuild: Support split debug info v4 Michal Marek
2014-07-30 18:44   ` Andi Kleen
  -- strict thread matches above, loose matches on Subject: below --
2014-07-15 23:16 [PATCH 1/2] kbuild: Support split debug info v3 Andi Kleen
2014-07-15 23:16 ` [PATCH 2/2] Kbuild: Add a option to enable dwarf4 Andi Kleen
2014-07-20 19:23   ` Sam Ravnborg
2014-07-20 21:17     ` Andi Kleen
2014-05-16 22:06 [PATCH 1/2] kbuild: Support split debug info v3 Andi Kleen
2014-05-16 22:06 ` [PATCH 2/2] Kbuild: Add a option to enable dwarf4 Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D8F550.2070800@suse.cz \
    --to=mmarek@suse.cz \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.