All of lore.kernel.org
 help / color / mirror / Atom feed
From: afaerber@suse.de (Andreas Färber)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] clk: initial clock driver for TWL6030
Date: Wed, 30 Jul 2014 16:29:45 +0200	[thread overview]
Message-ID: <53D90159.7040307@suse.de> (raw)
In-Reply-To: <1406728949-7560-3-git-send-email-sassmann@kpanic.de>

Hi Stefan,

Glad you got it working. :)

Small nit below:

Am 30.07.2014 16:02, schrieb Stefan Assmann:
> diff --git a/drivers/clk/ti/clk-6030.c b/drivers/clk/ti/clk-6030.c
> new file mode 100644
> index 0000000..baa965b
> --- /dev/null
> +++ b/drivers/clk/ti/clk-6030.c
> @@ -0,0 +1,141 @@
> +/*
> + * drivers/clk/ti/clk-6030.c
> + *
> + *  Copyright (C) 2014 Stefan Assmann <sassmann@kpanic.de>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.

Here you say version 2 ...

> + *
> + * Clock driver for ti twl6030.
> + */
[...]
> +MODULE_AUTHOR("Stefan Assmann <sassmann@kpanic.de>");
> +MODULE_DESCRIPTION("clock driver for TI SoC based boards with twl6030");
> +MODULE_LICENSE("GPL");

... but down here it's "GPL". Either use "GPL v2" here, or IIUC use the
"or (at your option) any later version" license above if you can.

Cheers,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg

WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber@suse.de>
To: Stefan Assmann <sassmann@kpanic.de>,
	linux-arm-kernel@lists.infradead.org
Cc: devicetree@vger.kernel.org, mturquette@linaro.org,
	pawel.moll@arm.com, robh+dt@kernel.org, t-kristo@ti.com,
	broonie@kernel.org
Subject: Re: [PATCH 2/2] clk: initial clock driver for TWL6030
Date: Wed, 30 Jul 2014 16:29:45 +0200	[thread overview]
Message-ID: <53D90159.7040307@suse.de> (raw)
In-Reply-To: <1406728949-7560-3-git-send-email-sassmann@kpanic.de>

Hi Stefan,

Glad you got it working. :)

Small nit below:

Am 30.07.2014 16:02, schrieb Stefan Assmann:
> diff --git a/drivers/clk/ti/clk-6030.c b/drivers/clk/ti/clk-6030.c
> new file mode 100644
> index 0000000..baa965b
> --- /dev/null
> +++ b/drivers/clk/ti/clk-6030.c
> @@ -0,0 +1,141 @@
> +/*
> + * drivers/clk/ti/clk-6030.c
> + *
> + *  Copyright (C) 2014 Stefan Assmann <sassmann@kpanic.de>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.

Here you say version 2 ...

> + *
> + * Clock driver for ti twl6030.
> + */
[...]
> +MODULE_AUTHOR("Stefan Assmann <sassmann@kpanic.de>");
> +MODULE_DESCRIPTION("clock driver for TI SoC based boards with twl6030");
> +MODULE_LICENSE("GPL");

... but down here it's "GPL". Either use "GPL v2" here, or IIUC use the
"or (at your option) any later version" license above if you can.

Cheers,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

  reply	other threads:[~2014-07-30 14:29 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-30 14:02 [PATCH 0/2] Enable wifi on pandaboard Stefan Assmann
2014-07-30 14:02 ` Stefan Assmann
2014-07-30 14:02 ` [PATCH 1/2] mfd: twl-core: move TWL6030 defines to twl.h Stefan Assmann
2014-07-30 14:02   ` Stefan Assmann
2014-07-31  8:36   ` Lee Jones
2014-07-31  8:36     ` Lee Jones
2014-07-31  8:46     ` Stefan Assmann
2014-07-31  8:46       ` Stefan Assmann
2014-07-30 14:02 ` [PATCH 2/2] clk: initial clock driver for TWL6030 Stefan Assmann
2014-07-30 14:02   ` Stefan Assmann
2014-07-30 14:29   ` Andreas Färber [this message]
2014-07-30 14:29     ` Andreas Färber
2014-07-30 14:36     ` Stefan Assmann
2014-07-30 14:36       ` Stefan Assmann
2014-07-30 17:50   ` Mark Brown
2014-07-30 17:50     ` Mark Brown
2014-07-31  9:56     ` Stefan Assmann
2014-07-31  9:56       ` Stefan Assmann
2014-07-31 11:05       ` Mark Brown
2014-07-31 11:05         ` Mark Brown
2014-07-31 12:04         ` Stefan Assmann
2014-07-31 12:04           ` Stefan Assmann
2014-07-31 19:14           ` Mike Turquette
2014-07-31 19:14             ` Mike Turquette
2014-07-31 11:28       ` Tero Kristo
2014-07-31 11:28         ` Tero Kristo
2014-07-31 11:58         ` Stefan Assmann
2014-07-31 11:58           ` Stefan Assmann
2014-07-31 13:16           ` Tero Kristo
2014-07-31 13:16             ` Tero Kristo
2014-07-31 12:26   ` Peter Ujfalusi
2014-07-31 12:26     ` Peter Ujfalusi
2014-07-31 12:54     ` Stefan Assmann
2014-07-31 12:54       ` Stefan Assmann
2014-07-31 12:58       ` Peter Ujfalusi
2014-07-31 12:58         ` Peter Ujfalusi
2014-07-31 14:05         ` Stefan Assmann
2014-07-31 14:05           ` Stefan Assmann
2014-07-31 19:20           ` Mike Turquette
2014-07-31 19:20             ` Mike Turquette
2014-08-01 10:04             ` Stefan Assmann
2014-08-01 10:04               ` Stefan Assmann
2014-08-01 10:38               ` Mark Brown
2014-08-01 10:38                 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D90159.7040307@suse.de \
    --to=afaerber@suse.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.