From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Subject: Re: [PATCH 2/2] brd: Fix brd_direct_access with partitions Date: Wed, 30 Jul 2014 18:37:43 +0300 Message-ID: <53D91147.6050907@plexistor.com> References: <53D7CDDD.1000302@gmail.com> <1406654379.2767.1.camel@rzwisler-mobl1.amr.corp.intel.com> <53D8D2C4.1030101@gmail.com> <53D8FE1F.1060009@plexistor.com> <53D8FEC7.8020804@plexistor.com> <20140730153402.GP6754@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pa0-f53.google.com ([209.85.220.53]:49497 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753466AbaG3Pht (ORCPT ); Wed, 30 Jul 2014 11:37:49 -0400 Received: by mail-pa0-f53.google.com with SMTP id rd3so1721207pab.12 for ; Wed, 30 Jul 2014 08:37:48 -0700 (PDT) In-Reply-To: <20140730153402.GP6754@linux.intel.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Matthew Wilcox Cc: Jens Axboe , Ross Zwisler , linux-scsi , Nick Piggin , linux-kernel On 07/30/2014 06:34 PM, Matthew Wilcox wrote: > On Wed, Jul 30, 2014 at 05:18:47PM +0300, Boaz Harrosh wrote: >> When brd_direct_access() is called on a partition-bdev >> it would access the wrong sector. And caller would then >> corrupt the device's data. >> >> This is a preliminary fix, Matthew Wilcox has a patch >> in his DAX patchset which will define a global wrapper >> to bdev->bd_disk->fops->direct_access that will do the >> proper checks and translations before calling a driver >> global member. (The way it is done at the rest of the >> block stack) > > Uh, no, let's just focus on getting the DAX code in instead of putting > in interim patches that will conflict. Patch 4/22 is uncontroversial, > fixes this problem, has no dependencies, and is key to the rest of the DAX > patchset. If this problem wants to be fixed, then put 4/22 in instead. > OK, I agree, could you please push 4/22 as reply to here for Jens to take for 3.17 ? (together with my 1/2) Thanks Boaz