From: Josef Bacik <jbacik@fb.com>
To: Johannes Berg <johannes@sipsolutions.net>,
Steven Rostedt <rostedt@goodmis.org>
Cc: <linux-kernel@vger.kernel.org>, Darren Hart <darren@dvhart.com>
Subject: Re: [PATCH] trace-cmd: add trace-record.o to the python shared lib
Date: Wed, 30 Jul 2014 12:11:36 -0400 [thread overview]
Message-ID: <53D91938.6070406@fb.com> (raw)
In-Reply-To: <1406033927.32255.33.camel@jlt4.sipsolutions.net>
On 07/22/2014 08:58 AM, Johannes Berg wrote:
> On Mon, 2014-07-21 at 17:01 -0400, Steven Rostedt wrote:
>> Cc'd my python gurus.
>>
>> Acks?
>
>>> When trying to use the python library it was giving me an error about not being
>>> able to resolve tracecmd_stat_cpu. This is because we weren't linking
>>> trace-record.o to ctracecmd.so. Fix this in the makefile and now I can import
>>> trace-cmd in python properly. Thanks,
>
> I guess, I don't see anything wrong with that. I don't usually use
> ctracecmd.so standalone, only as part of trace-cmd, which may explain
> why I didn't see any problem?
>
Maybe? I'm not sure how it worked for you, with just a normal install I can
load up python and import tracecmd and it blows up immediately. This is
pointing at the /usr/local/lib/trace-cmd/python stuff, not using it from
trace-cmd directly. Steve can you take these two patches so I can close out my
internal stuff? I don't like carrying patches I can't point at an upstream
commit for. Thanks,
Josef
prev parent reply other threads:[~2014-07-30 16:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 20:50 [PATCH] trace-cmd: add trace-record.o to the python shared lib Josef Bacik
2014-07-21 21:01 ` Steven Rostedt
2014-07-22 12:58 ` Johannes Berg
2014-07-30 16:11 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D91938.6070406@fb.com \
--to=jbacik@fb.com \
--cc=darren@dvhart.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.