From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>,
Jun Nakajima <jun.nakajima@intel.com>,
Eddie Dong <eddie.dong@intel.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Ian Campbell <Ian.Campbell@eu.citrix.com>,
Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>,
suravee.suthikulpanit@amd.com
Subject: Re: [PATCH 3/3] x86/HVM: command line option adjustments
Date: Wed, 30 Jul 2014 12:55:54 -0400 [thread overview]
Message-ID: <53D9239A.9070803@oracle.com> (raw)
In-Reply-To: <53D934E50200007800027BC2@mail.emea.novell.com>
On 07/30/2014 12:09 PM, Jan Beulich wrote:
>
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -70,8 +70,10 @@
>
> bool_t __read_mostly hvm_enabled;
>
> +#ifdef DBG_LEVEL_0
> unsigned int opt_hvm_debug_level __read_mostly;
> integer_param("hvm_debug", opt_hvm_debug_level);
> +#endif
Do you think "#ifndef NDEBUG" might be better given that it is what
defines DBG_LEVEL_0 (and all other DBG_LEVELs)?
-boris
next prev parent reply other threads:[~2014-07-30 16:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 16:04 [PATCH 0/3] x86: command line option adjustments Jan Beulich
2014-07-30 16:07 ` [PATCH 1/3] x86/ACPI: " Jan Beulich
2014-07-30 16:08 ` [PATCH 2/3] x86/APIC: " Jan Beulich
2014-07-30 16:09 ` [PATCH 3/3] x86/HVM: " Jan Beulich
2014-07-30 16:55 ` Boris Ostrovsky [this message]
2014-07-31 22:55 ` Tian, Kevin
2014-08-01 6:31 ` Jan Beulich
2014-08-01 23:23 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D9239A.9070803@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=Ian.Campbell@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=aravind.gopalakrishnan@amd.com \
--cc=eddie.dong@intel.com \
--cc=jun.nakajima@intel.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.