Re: [PATCH RFC 4/9] xen: arm: move setup_virt_paging to p2m.c

[Julien Grall <julien.grall@linaro.org>]

Hi Ian,

On 07/30/2014 02:47 PM, Ian Campbell wrote:
> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
> index 6839acf..705b29b 100644
> --- a/xen/arch/arm/p2m.c
> +++ b/xen/arch/arm/p2m.c
> @@ -1059,6 +1059,24 @@ err:
>      return page;
>  }
>  
> +void __cpuinit setup_virt_paging(void)
> +{
> +    /* Setup Stage 2 address translation */
> +    /* SH0=11 (Inner-shareable)
> +     * ORGN0=IRGN0=01 (Normal memory, Write-Back Write-Allocate Cacheable)
> +     * SL0=01 (Level-1)
> +     * ARVv7: T0SZ=(1)1000 = -8 (32-(-8) = 40 bit physical addresses)
> +     * ARMv8: T0SZ=01 1000 = 24 (64-24   = 40 bit physical addresses)
> +     *        PS=010 == 40 bits
> +     */
> +#ifdef CONFIG_ARM_32
> +    WRITE_SYSREG32(0x80003558, VTCR_EL2);
> +#else
> +    WRITE_SYSREG32(0x80023558, VTCR_EL2);
> +#endif
> +    isb();
> +}
> +
>  /*
>   * Local variables:
>   * mode: C
> 

To consistent, I would also move the definition of setup_virt_paging
from mm.h to p2m.h.

I will let you choose on this so:

Acked-by: Julien Grall <julien.grall@linaro.org>


-- 
Julien Grall