From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Debabrata Banerjee <dbanerje@akamai.com>,
netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>
Cc: Julian Anastasov <ja@ssi.bg>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tcp: don't require root to read tcp_metrics
Date: Wed, 30 Jul 2014 21:38:26 +0400 [thread overview]
Message-ID: <53D92D92.4090403@cogentembedded.com> (raw)
In-Reply-To: <1406740415-9386-1-git-send-email-dbanerje@akamai.com>
Hello.
On 07/30/2014 09:13 PM, Debabrata Banerjee wrote:
> commit d23ff701643a4a725e2c7a8ba2d567d39daa29ea introduced netlink support for
Please also specify that commit's summary line in parens.
> the new tcp_metrics, however it restricted getting of tcp_metrics to root user
> only. This is a change from how these values could have been fetched when in
> the old route cache. Unless there's a legitimate reason to restrict the reading
> of these values it would be better if normal users could fetch them.
> Cc: Julian Anastasov <ja@ssi.bg>
> Cc: linux-kernel@vger.kernel.org
You need to sign off on the patch, else it couldn't be applied.
WBR, Sergei
next prev parent reply other threads:[~2014-07-30 17:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 17:13 [PATCH] tcp: don't require root to read tcp_metrics Debabrata Banerjee
2014-07-30 17:38 ` Sergei Shtylyov [this message]
2014-07-30 17:50 ` [PATCH v2] " Debabrata Banerjee
2014-07-31 21:07 ` David Miller
2014-07-30 19:33 ` [PATCH] " Julian Anastasov
2014-07-30 19:58 ` Banerjee, Debabrata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D92D92.4090403@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=dbanerje@akamai.com \
--cc=ja@ssi.bg \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.