From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCg0I-00022R-1x for qemu-devel@nongnu.org; Wed, 30 Jul 2014 22:22:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XCg0D-00019Q-LB for qemu-devel@nongnu.org; Wed, 30 Jul 2014 22:22:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53444) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCg0D-00019M-E3 for qemu-devel@nongnu.org; Wed, 30 Jul 2014 22:21:57 -0400 Message-ID: <53D9A836.6080007@redhat.com> Date: Wed, 30 Jul 2014 20:21:42 -0600 From: Eric Blake MIME-Version: 1.0 References: <1406349933-17536-1-git-send-email-arei.gonglei@huawei.com> <1406349933-17536-3-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1406349933-17536-3-git-send-email-arei.gonglei@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Deus4FnnsuSnBFKGgUpLl7DpafDPMoCsC" Subject: Re: [Qemu-devel] [PATCH v3 2/7] bootindex: add del_boot_device_path function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: chenliang88@huawei.com, weidong.huang@huawei.com, mst@redhat.com, aik@ozlabs.ru, hutao@cn.fujitsu.com, armbru@redhat.com, kraxel@redhat.com, akong@redhat.com, agraf@suse.de, aliguori@amazon.com, gaowanlong@cn.fujitsu.com, ehabkost@redhat.com, luonengjun@huawei.com, peter.huangpeng@huawei.com, hani@linux.com, stefanha@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, kwolf@redhat.com, peter.crosthwaite@xilinx.com, imammedo@redhat.com, afaerber@suse.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Deus4FnnsuSnBFKGgUpLl7DpafDPMoCsC Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/25/2014 10:45 PM, arei.gonglei@huawei.com wrote: > From: Gonglei >=20 > Introduce a del_boot_device_path() cleanup fw_cfg content > when hot-unplugging devcie refer to bootindex. s/devcie/device/ sounds odd; maybe: Introduce del_boot_device_path() to clean up fw_cfg content when hot-unplugging a device that refers to a bootindex. > + > + QTAILQ_FOREACH(i, &fw_boot_order, link) { > + if (i->dev->id && dev->id && !strcmp(i->dev->id, dev->id)) { > + /* remove all entries of the assigend dev */ s/assigend/assigned/ --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Deus4FnnsuSnBFKGgUpLl7DpafDPMoCsC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT2ag2AAoJEKeha0olJ0NqoLwH/3TelvIFxHTv8WH4OfxZaz31 U5HzKZiXTrsfACEptielRzQZWSb3JVag0Nt75lIkUlNJXZ53KJmfmyHsr9VtVY2L L507ldfOB99gRufnE2c7Z8UYFlWMNSdyFi/Xtuhhnl60ic5TBcSySmfYW1zUY0vZ qVd8lv/xt+tnJwJq9dzYrraVyEZv2D8/1KCvwSa3IBxKKswT4jIFgJuXJWzD0OX2 zSHYM/uMY3mQ3F1D5UXU/Y4+fIIDrJn7X/P5jNYOcVvCO0qKobfhNoSQBkiInNp3 UjK4wk0TML6Qx/MMWoGreOiG76bAgrKfqiHiYGESbVPEPuA7qAN6WRSKVvGjWio= =/upl -----END PGP SIGNATURE----- --Deus4FnnsuSnBFKGgUpLl7DpafDPMoCsC--