From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Subject: Re: [PATCH v3 4/4] ARM: dts: Add exynos5250-spring device tree Date: Thu, 31 Jul 2014 11:26:02 +0200 Message-ID: <53DA0BAA.8090000@suse.de> References: <1406728244-5105-1-git-send-email-afaerber@suse.de> <1406728244-5105-5-git-send-email-afaerber@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1406728244-5105-5-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Stephan van Schaik , Vincent Palatin , Doug Anderson , Javier Martinez Canillas , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Ben Dooks , Kukjin Kim , LKML , Ajay Kumar List-Id: linux-samsung-soc@vger.kernel.org Am 30.07.2014 15:50, schrieb Andreas F=C3=A4rber: > diff --git a/arch/arm/boot/dts/exynos5250-spring.dts b/arch/arm/boot/= dts/exynos5250-spring.dts > new file mode 100644 > index 000000000000..bcca892bf2ff > --- /dev/null > +++ b/arch/arm/boot/dts/exynos5250-spring.dts [...] > +&pinctrl_0 { > + dp_hpd_gpio: dp-hpd-gpio { > + samsung,pins =3D "gpc3-0"; > + samsung,pin-function =3D <1>; Not sure where this 1 came from... Both Ajay and my 3.8 DT have 0. > + samsung,pin-pud =3D <3>; > + samsung,pin-drv =3D <0>; > + }; Seeing that Ajay called this node dp-hdp, it should probably be an over= ride? &dp_hpd { ... }; Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3= =BCrnberg -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: afaerber@suse.de (=?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?=) Date: Thu, 31 Jul 2014 11:26:02 +0200 Subject: [PATCH v3 4/4] ARM: dts: Add exynos5250-spring device tree In-Reply-To: <1406728244-5105-5-git-send-email-afaerber@suse.de> References: <1406728244-5105-1-git-send-email-afaerber@suse.de> <1406728244-5105-5-git-send-email-afaerber@suse.de> Message-ID: <53DA0BAA.8090000@suse.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am 30.07.2014 15:50, schrieb Andreas F?rber: > diff --git a/arch/arm/boot/dts/exynos5250-spring.dts b/arch/arm/boot/dts/exynos5250-spring.dts > new file mode 100644 > index 000000000000..bcca892bf2ff > --- /dev/null > +++ b/arch/arm/boot/dts/exynos5250-spring.dts [...] > +&pinctrl_0 { > + dp_hpd_gpio: dp-hpd-gpio { > + samsung,pins = "gpc3-0"; > + samsung,pin-function = <1>; Not sure where this 1 came from... Both Ajay and my 3.8 DT have 0. > + samsung,pin-pud = <3>; > + samsung,pin-drv = <0>; > + }; Seeing that Ajay called this node dp-hdp, it should probably be an override? &dp_hpd { ... }; Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932416AbaGaJ0L (ORCPT ); Thu, 31 Jul 2014 05:26:11 -0400 Received: from cantor2.suse.de ([195.135.220.15]:55185 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932397AbaGaJ0I (ORCPT ); Thu, 31 Jul 2014 05:26:08 -0400 Message-ID: <53DA0BAA.8090000@suse.de> Date: Thu, 31 Jul 2014 11:26:02 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Organization: SUSE LINUX Products GmbH User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: linux-samsung-soc@vger.kernel.org CC: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Stephan van Schaik , Vincent Palatin , Doug Anderson , Javier Martinez Canillas , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Ben Dooks , Kukjin Kim , LKML , Ajay Kumar Subject: Re: [PATCH v3 4/4] ARM: dts: Add exynos5250-spring device tree References: <1406728244-5105-1-git-send-email-afaerber@suse.de> <1406728244-5105-5-git-send-email-afaerber@suse.de> In-Reply-To: <1406728244-5105-5-git-send-email-afaerber@suse.de> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 30.07.2014 15:50, schrieb Andreas Färber: > diff --git a/arch/arm/boot/dts/exynos5250-spring.dts b/arch/arm/boot/dts/exynos5250-spring.dts > new file mode 100644 > index 000000000000..bcca892bf2ff > --- /dev/null > +++ b/arch/arm/boot/dts/exynos5250-spring.dts [...] > +&pinctrl_0 { > + dp_hpd_gpio: dp-hpd-gpio { > + samsung,pins = "gpc3-0"; > + samsung,pin-function = <1>; Not sure where this 1 came from... Both Ajay and my 3.8 DT have 0. > + samsung,pin-pud = <3>; > + samsung,pin-drv = <0>; > + }; Seeing that Ajay called this node dp-hdp, it should probably be an override? &dp_hpd { ... }; Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg