From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38168) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCp6u-0001YY-IG for qemu-devel@nongnu.org; Thu, 31 Jul 2014 08:05:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XCp6l-0004oB-7R for qemu-devel@nongnu.org; Thu, 31 Jul 2014 08:05:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31665) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCp6l-0004nv-0H for qemu-devel@nongnu.org; Thu, 31 Jul 2014 08:05:19 -0400 Message-ID: <53DA30FA.6060808@redhat.com> Date: Thu, 31 Jul 2014 14:05:14 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1406716032-21795-1-git-send-email-pbonzini@redhat.com> <1406716032-21795-10-git-send-email-pbonzini@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 9/9] tpm_tis: remove instance_finalize callback List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: "qemu-devel@nongnu.org Developers" Il 31/07/2014 14:00, Peter Crosthwaite ha scritto: > On Wed, Jul 30, 2014 at 8:27 PM, Paolo Bonzini wrote: >> It is never used, since ISA device are not hot-unpluggable. >> > > Is it not good design practice though for the uninit to be correctly > implemented regardless of whether there is current-day usage? This > seems like the kind of patch that would get reverted if anyone finds a > reason to un-init a QOM object beyond existing hotplug use-cases. But even then, it should be an unrealize method, not an instance_finalize, shouldn't it? Paolo > Regards, > Peter > >> Signed-off-by: Paolo Bonzini >> --- >> hw/tpm/tpm_tis.c | 8 -------- >> 1 file changed, 8 deletions(-) >> >> diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c >> index d398c16..82747ee 100644 >> --- a/hw/tpm/tpm_tis.c >> +++ b/hw/tpm/tpm_tis.c >> @@ -896,13 +896,6 @@ static void tpm_tis_initfn(Object *obj) >> &s->mmio); >> } >> >> -static void tpm_tis_uninitfn(Object *obj) >> -{ >> - TPMState *s = TPM(obj); >> - >> - memory_region_del_subregion(get_system_memory(), &s->mmio); >> -} >> - >> static void tpm_tis_class_init(ObjectClass *klass, void *data) >> { >> DeviceClass *dc = DEVICE_CLASS(klass); >> @@ -918,7 +911,6 @@ static const TypeInfo tpm_tis_info = { >> .parent = TYPE_ISA_DEVICE, >> .instance_size = sizeof(TPMState), >> .instance_init = tpm_tis_initfn, >> - .instance_finalize = tpm_tis_uninitfn, >> .class_init = tpm_tis_class_init, >> }; >> >> -- >> 1.8.3.1 >> >>