All of lore.kernel.org
 help / color / mirror / Atom feed
From: t-kristo@ti.com (Tero Kristo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] clk: initial clock driver for TWL6030
Date: Thu, 31 Jul 2014 16:16:17 +0300	[thread overview]
Message-ID: <53DA41A1.5010900@ti.com> (raw)
In-Reply-To: <53DA2F53.8010405@kpanic.de>

<snip>

>>> +static int of_twl6030_clk32kg_probe(struct platform_device *pdev)
>>> +{
>>> +	struct device_node *node = pdev->dev.of_node;
>>> +	struct clk *clk;
>>> +
>>> +	if (!node)
>>> +		return -ENODEV;
>>> +
>>> +	clk = devm_clk_get(&pdev->dev, "clk32kg");
>>> +	if (IS_ERR(clk))
>>> +		return PTR_ERR(clk);
>>> +
>>> +	return clk_prepare(clk);
>>
>> This is plain wrong as pointed out earlier. The driver that uses the
>> clock must enable it.
>
> Understood. I'll change it to clk_prepare_enable().

Nono, remove it completely from here. The clock driver should not enable 
itself by default. The clock itself has some sort of customer somewhere 
(like am33xx-wifi driver), which should request for the clock and enable 
it only when needed.

-Tero

WARNING: multiple messages have this Message-ID (diff)
From: Tero Kristo <t-kristo-l0cyMroinI0@public.gmane.org>
To: Stefan Assmann <sassmann-llIHtaV5axyzQB+pC5nmwQ@public.gmane.org>,
	Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	pawel.moll-5wv7dgnIgG8@public.gmane.org,
	peter.ujfalusi-l0cyMroinI0@public.gmane.org,
	"Andreas Färber" <afaerber-l3A5Bk7waGM@public.gmane.org>
Subject: Re: [PATCH 2/2] clk: initial clock driver for TWL6030
Date: Thu, 31 Jul 2014 16:16:17 +0300	[thread overview]
Message-ID: <53DA41A1.5010900@ti.com> (raw)
In-Reply-To: <53DA2F53.8010405-llIHtaV5axyzQB+pC5nmwQ@public.gmane.org>

<snip>

>>> +static int of_twl6030_clk32kg_probe(struct platform_device *pdev)
>>> +{
>>> +	struct device_node *node = pdev->dev.of_node;
>>> +	struct clk *clk;
>>> +
>>> +	if (!node)
>>> +		return -ENODEV;
>>> +
>>> +	clk = devm_clk_get(&pdev->dev, "clk32kg");
>>> +	if (IS_ERR(clk))
>>> +		return PTR_ERR(clk);
>>> +
>>> +	return clk_prepare(clk);
>>
>> This is plain wrong as pointed out earlier. The driver that uses the
>> clock must enable it.
>
> Understood. I'll change it to clk_prepare_enable().

Nono, remove it completely from here. The clock driver should not enable 
itself by default. The clock itself has some sort of customer somewhere 
(like am33xx-wifi driver), which should request for the clock and enable 
it only when needed.

-Tero

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2014-07-31 13:16 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-30 14:02 [PATCH 0/2] Enable wifi on pandaboard Stefan Assmann
2014-07-30 14:02 ` Stefan Assmann
2014-07-30 14:02 ` [PATCH 1/2] mfd: twl-core: move TWL6030 defines to twl.h Stefan Assmann
2014-07-30 14:02   ` Stefan Assmann
2014-07-31  8:36   ` Lee Jones
2014-07-31  8:36     ` Lee Jones
2014-07-31  8:46     ` Stefan Assmann
2014-07-31  8:46       ` Stefan Assmann
2014-07-30 14:02 ` [PATCH 2/2] clk: initial clock driver for TWL6030 Stefan Assmann
2014-07-30 14:02   ` Stefan Assmann
2014-07-30 14:29   ` Andreas Färber
2014-07-30 14:29     ` Andreas Färber
2014-07-30 14:36     ` Stefan Assmann
2014-07-30 14:36       ` Stefan Assmann
2014-07-30 17:50   ` Mark Brown
2014-07-30 17:50     ` Mark Brown
2014-07-31  9:56     ` Stefan Assmann
2014-07-31  9:56       ` Stefan Assmann
2014-07-31 11:05       ` Mark Brown
2014-07-31 11:05         ` Mark Brown
2014-07-31 12:04         ` Stefan Assmann
2014-07-31 12:04           ` Stefan Assmann
2014-07-31 19:14           ` Mike Turquette
2014-07-31 19:14             ` Mike Turquette
2014-07-31 11:28       ` Tero Kristo
2014-07-31 11:28         ` Tero Kristo
2014-07-31 11:58         ` Stefan Assmann
2014-07-31 11:58           ` Stefan Assmann
2014-07-31 13:16           ` Tero Kristo [this message]
2014-07-31 13:16             ` Tero Kristo
2014-07-31 12:26   ` Peter Ujfalusi
2014-07-31 12:26     ` Peter Ujfalusi
2014-07-31 12:54     ` Stefan Assmann
2014-07-31 12:54       ` Stefan Assmann
2014-07-31 12:58       ` Peter Ujfalusi
2014-07-31 12:58         ` Peter Ujfalusi
2014-07-31 14:05         ` Stefan Assmann
2014-07-31 14:05           ` Stefan Assmann
2014-07-31 19:20           ` Mike Turquette
2014-07-31 19:20             ` Mike Turquette
2014-08-01 10:04             ` Stefan Assmann
2014-08-01 10:04               ` Stefan Assmann
2014-08-01 10:38               ` Mark Brown
2014-08-01 10:38                 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53DA41A1.5010900@ti.com \
    --to=t-kristo@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.