From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= Subject: Re: [PATCH] drm/msm/hdmi: enable lpm-mux if it is present Date: Thu, 31 Jul 2014 17:06:25 +0200 Message-ID: <53DA5B71.90004@suse.de> References: <1406818005-21953-1-git-send-email-sviau@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from cantor2.suse.de ([195.135.220.15]:33940 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751003AbaGaPG3 (ORCPT ); Thu, 31 Jul 2014 11:06:29 -0400 In-Reply-To: <1406818005-21953-1-git-send-email-sviau@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Stephane Viau , dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, robdclark@gmail.com, Beeresh Gopal Hi, Am 31.07.2014 16:46, schrieb Stephane Viau: > From: Beeresh Gopal >=20 > lpm-mux is programmed to enable HDMI connector > on the docking station for S805 chipset based > devices. >=20 > Signed-off-by: Beeresh Gopal You forgot to sign off yourself. [...] > diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c b/drivers/gpu/= drm/msm/hdmi/hdmi_connector.c > index 93d1551..1301d03 100644 > --- a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c > +++ b/drivers/gpu/drm/msm/hdmi/hdmi_connector.c > @@ -63,7 +63,8 @@ static int gpio_config(struct hdmi *hdmi, bool on) > ret =3D gpio_request(config->mux_en_gpio, "HDMI_MUX_EN"); > if (ret) { > dev_err(dev->dev, "'%s'(%d) gpio_request failed: %d\n", > - "HDMI_MUX_SEL", config->mux_en_gpio, ret); > + "HDMI_MUX_EN", > + config->mux_en_gpio, ret); > goto error4; > } > gpio_set_value_cansleep(config->mux_en_gpio, 1); This hunk looks like an unrelated typo fix, which should then probably go into its own patch. Cheers, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrn= berg