From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 15/16] RFC: dm: tegra: Enable driver model for serial
Date: Thu, 31 Jul 2014 14:18:50 -0600 [thread overview]
Message-ID: <53DAA4AA.8050004@wwwdotorg.org> (raw)
In-Reply-To: <1406713793-12828-16-git-send-email-sjg@chromium.org>
On 07/30/2014 03:49 AM, Simon Glass wrote:
> Use driver model for serial ports (for test and comment only).
A couple of nits:
> diff --git a/include/configs/tegra-common.h b/include/configs/tegra-common.h
> #define CONFIG_SYS_MALLOC_LEN (4 << 20) /* 4MB */
> +#define CONFIG_SYS_MALLOC_F_LEN (1 << 10)
README says:
Pre-relocation malloc() is only supported on sandbox
@present but is fairly easy to enable for other archs.
I assume that should be deleted now.
>
> /*
> * NS16550 Configuration
> */
> -#define CONFIG_SYS_NS16550
> +#ifdef CONFIG_SPL_BUILD
> #define CONFIG_SYS_NS16550_SERIAL
> #define CONFIG_SYS_NS16550_REG_SIZE (-4)
> #define CONFIG_SYS_NS16550_CLK V_NS16550_CLK
> +#endif
> +#define CONFIG_SYS_NS16550
Leaving that define in the same place would simplify the diff.
next prev parent reply other threads:[~2014-07-31 20:18 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 9:49 [U-Boot] [PATCH v3 0/16] Introduce driver model serial uclass Simon Glass
2014-07-30 9:49 ` [U-Boot] [PATCH v3 01/16] serial: Set up the 'priv' pointer when creating a serial device Simon Glass
2014-07-30 9:49 ` [U-Boot] [PATCH v3 02/16] dm: Adjust lists_bind_fdt() to return the bound device Simon Glass
2014-07-30 9:49 ` [U-Boot] [PATCH v3 03/16] dm: Add a uclass for serial devices Simon Glass
2014-07-30 9:49 ` [U-Boot] [PATCH v3 04/16] Set up stdio earlier when using driver model Simon Glass
2014-07-30 9:49 ` [U-Boot] [PATCH v3 05/16] sandbox: Convert serial driver to use " Simon Glass
2014-07-30 9:49 ` [U-Boot] [PATCH v3 06/16] sandbox: serial: Support a coloured console Simon Glass
2014-07-30 9:49 ` [U-Boot] [PATCH v3 07/16] sandbox: dts: Add a serial console node Simon Glass
2014-07-31 20:20 ` Stephen Warren
2014-07-31 22:13 ` Simon Glass
2014-07-31 23:09 ` Stephen Warren
2014-08-01 15:46 ` Jon Loeliger
2014-08-01 16:53 ` Tom Rini
2014-08-01 21:37 ` Simon Glass
2014-08-01 21:40 ` Simon Glass
2014-08-01 21:52 ` Stephen Warren
2014-07-30 9:49 ` [U-Boot] [PATCH v3 08/16] dm: exynos: Mark exynos5 console as pre-reloc Simon Glass
2014-07-30 9:49 ` [U-Boot] [PATCH v3 09/16] dm: exynos: Move serial to driver model Simon Glass
2014-07-30 15:38 ` Tom Rini
2014-07-30 15:43 ` Simon Glass
2014-07-30 9:49 ` [U-Boot] [PATCH v3 10/16] dm: Make driver model available before board_init() Simon Glass
2014-07-30 9:49 ` [U-Boot] [PATCH v3 11/16] dm: serial: Move baud rate calculation to ns16550.c Simon Glass
2014-07-30 9:49 ` [U-Boot] [PATCH v3 12/16] dm: serial: Collect common baud rate code in ns16550 Simon Glass
2014-07-30 9:49 ` [U-Boot] [PATCH v3 13/16] dm: serial: Add driver model support for ns16550 Simon Glass
2014-07-30 9:49 ` [U-Boot] [PATCH v3 14/16] tegra: dts: Add serial port details Simon Glass
2014-07-31 20:16 ` Stephen Warren
2014-07-31 22:10 ` Simon Glass
2014-07-31 23:06 ` Stephen Warren
2014-08-01 21:32 ` Simon Glass
2014-08-01 21:50 ` Stephen Warren
2014-08-04 10:43 ` Simon Glass
2014-08-04 17:47 ` Stephen Warren
2014-08-04 18:11 ` Tom Rini
2014-08-04 18:47 ` Jeroen Hofstee
2014-08-04 20:14 ` Simon Glass
2014-08-05 16:05 ` Stephen Warren
2014-07-30 9:49 ` [U-Boot] [PATCH v3 15/16] RFC: dm: tegra: Enable driver model for serial Simon Glass
2014-07-31 20:18 ` Stephen Warren [this message]
2014-07-31 22:11 ` Simon Glass
2014-07-30 9:49 ` [U-Boot] [PATCH v3 16/16] dm: tegra: Use V_NS16550_CLK only in SPL builds Simon Glass
2014-07-31 20:22 ` Stephen Warren
2014-07-31 22:14 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DAA4AA.8050004@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.