From: Edward Shishkin <edward.shishkin@gmail.com>
To: Ivan Shapovalov <intelfx100@gmail.com>, reiserfs-devel@vger.kernel.org
Subject: Re: reiser4: FITRIM ioctl -- where to place the handler?
Date: Thu, 31 Jul 2014 23:37:34 +0200 [thread overview]
Message-ID: <53DAB71E.5020303@gmail.com> (raw)
In-Reply-To: <1888625.Xe1HFmG7T5@intelfx-laptop>
Do we really need this ioctl?
If we implement precise discard (with garbage collection),
then I don't see any applications for this ioctl..
Edward.
On 07/31/2014 04:23 PM, Ivan Shapovalov wrote:
> Hi,
>
> I've started to iterate on the batch mode discard implementation for reiser4,
> and the first question is -- where to place the ioctl handler?
>
> From what I've been able to understand, we need something like
> reiser4_ioctl_dir_common() in plugin/file_ops.c, pointer to which should
> become ->{unlocked,compat}_ioctl() of directory_f_ops in plugin/object.c.
>
> However, in this case, what is DIRECTORY_FILE_PLUGIN_ID and corresponding
> entry in file_plugins array in plugin/object.c? How is it related to
> directories?
>
> I see that its ->{inode,file,as}_ops are empty, so it probably does not
> participate in dispatching ioctls, but I'd like to make sure this is the case.
>
> Thanks,
next prev parent reply other threads:[~2014-07-31 21:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 14:23 reiser4: FITRIM ioctl -- where to place the handler? Ivan Shapovalov
2014-07-31 21:37 ` Edward Shishkin [this message]
2014-07-31 22:09 ` Ivan Shapovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DAB71E.5020303@gmail.com \
--to=edward.shishkin@gmail.com \
--cc=intelfx100@gmail.com \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.