Re: [Qemu-devel] [PATCH v2 for-2.2 0/8] about Yoda conditions

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]

On 07/31/2014 08:32 PM, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
> 
> $WHATEVER: don't use 'Yoda conditions'
> 
> 'Yoda conditions' are not part of idiomatic QEMU coding
> style, so rewrite them in the more usual order.
> 
> v2:
>  - add more specific commit messages suggested by PMM, thanks.
>  - introduce section of conditional statement to CODING_STYLE.
> 
> 
> Gonglei (8):
>   CODING_STYLE: Section about conditional statement
>   usb: a trivial code change for more idiomatic writing style

You didn't rename the subject lines.  I think the request you were given
on v1 was to name this patch:

usb: don't use 'Yoda conditions'

>   audio: a trivial code change for more idiomatic writing style

audio: don't use 'Yoda conditions'

>   isa-bus: a trivial code change for more idiomatic writing style
>   a trivial code change for more idiomatic writing style
>   spice: a trivial code change for more idiomatic writing style
>   vl: a trivial code change for more idiomatic writing style
>   vmxnet3: a trivial code change for more idiomatic writing style

and so on

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]