From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751959AbaHAOHA (ORCPT <rfc822;w@1wt.eu>);
	Fri, 1 Aug 2014 10:07:00 -0400
Received: from relay1.mentorg.com ([192.94.38.131]:45810 "EHLO
	relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750845AbaHAOG7 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 1 Aug 2014 10:06:59 -0400
Message-ID: <53DB9EFD.4040107@mentor.com>
Date: Fri, 1 Aug 2014 19:36:53 +0530
From: Vignesh Raman <Vignesh_Raman@mentor.com>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.0
MIME-Version: 1.0
To: Vinod Koul <vinod.koul@intel.com>
CC: <dan.j.williams@intel.com>, <dmaengine@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <Jiada_Wang@mentor.com>
Subject: Re: [PATCH 2/2] dma: imx-sdma: Adding tasklet_kill() in sdma_remove
 function.
References: <1406725875-9171-1-git-send-email-Vignesh_Raman@mentor.com> <1406725875-9171-3-git-send-email-Vignesh_Raman@mentor.com> <20140731120205.GT8181@intel.com>
In-Reply-To: <20140731120205.GT8181@intel.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [137.202.0.76]
X-OriginalArrivalTime: 01 Aug 2014 14:06:57.0834 (UTC) FILETIME=[DB4FD8A0:01CFAD91]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday 31 July 2014 05:32 PM, Vinod Koul wrote:
> On Wed, Jul 30, 2014 at 06:41:15PM +0530, Vignesh Raman wrote:
>> Several dma drivers calls tasklet_kill() in remove function. This is missing in
>> imx driver, so adding tasklet_kill() in sdma_remove function.
> And why should we do that ?
> 
This is done because all running tasklets should be killed on remove.

Regards,
Vignesh.