From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH v5 05/10] ARM: dts: Move dp_hpd from exynos5250 into smdk5250 and snow Date: Fri, 01 Aug 2014 22:57:06 +0200 Message-ID: <53DBFF22.3010905@gmail.com> References: <1406868897-26874-1-git-send-email-afaerber@suse.de> <1406868897-26874-6-git-send-email-afaerber@suse.de> <53DBFE8A.7020505@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-wi0-f179.google.com ([209.85.212.179]:41311 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754966AbaHAU5M (ORCPT ); Fri, 1 Aug 2014 16:57:12 -0400 In-Reply-To: <53DBFE8A.7020505@suse.de> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Doug Anderson Cc: linux-samsung-soc , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Stephan van Schaik , Vincent Palatin , Javier Martinez Canillas , Tomasz Figa , Ben Dooks , Kukjin Kim , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , open list On 01.08.2014 22:54, Andreas F=C3=A4rber wrote: > Doug, >=20 > Am 01.08.2014 22:33, schrieb Doug Anderson: >> On Thu, Jul 31, 2014 at 9:54 PM, Andreas F=C3=A4rber wrote: >>> Spring uses a different GPIO, so this is not a generic SoC piece. >>> >>> Suggested-by: Tomasz Figa >>> Signed-off-by: Andreas F=C3=A4rber >>> --- >>> v5: New (Tomasz Figa) >>> Frees dp_hpd for Spring. >>> >>> arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 7 ------- >>> arch/arm/boot/dts/exynos5250-smdk5250.dts | 9 +++++++++ >>> arch/arm/boot/dts/exynos5250-snow.dts | 7 +++++++ >>> 3 files changed, 16 insertions(+), 7 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi b/arch/arm/b= oot/dts/exynos5250-pinctrl.dtsi >>> index 886cfca044ac..ed0e5230514b 100644 >>> --- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi >>> +++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi >>> @@ -581,13 +581,6 @@ >>> samsung,pin-pud =3D <0>; >>> samsung,pin-drv =3D <0>; >>> }; >>> - >>> - dp_hpd: dp_hpd { >>> - samsung,pins =3D "gpx0-7"; >>> - samsung,pin-function =3D <3>; >>> - samsung,pin-pud =3D <0>; >>> - samsung,pin-drv =3D <0>; >>> - }; >>> }; >>> >>> pinctrl@13400000 { >>> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/b= oot/dts/exynos5250-smdk5250.dts >>> index aaa055ac0fe3..5d30fe1dcda4 100644 >>> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts >>> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts >>> @@ -414,3 +414,12 @@ >>> }; >>> }; >>> }; >>> + >>> +&pinctrl_0 { >>> + dp_hpd: dp_hpd { >>> + samsung,pins =3D "gpx0-7"; >>> + samsung,pin-function =3D <3>; >>> + samsung,pin-pud =3D <0>; >>> + samsung,pin-drv =3D <0>; >>> + }; >>> +}; >>> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/= dts/exynos5250-snow.dts >>> index c4b0c73c736d..a9a2f2743794 100644 >>> --- a/arch/arm/boot/dts/exynos5250-snow.dts >>> +++ b/arch/arm/boot/dts/exynos5250-snow.dts >>> @@ -547,6 +547,13 @@ >>> }; >>> >>> &pinctrl_0 { >>> + dp_hpd: dp_hpd { >>> + samsung,pins =3D "gpx0-7"; >>> + samsung,pin-function =3D <3>; >>> + samsung,pin-pud =3D <0>; >>> + samsung,pin-drv =3D <0>; >>> + }; >>> + >> >> NAK. dp_hpd is a generic SoC piece. Pin function 0 and 1 are GPIOs= =2E >> Pin function 3 is special function. This pin _is_ the hot plug dete= ct >> pin for display port. When it's set as special function 3 it goes >> straight into the hot plug logic of the display port controller. >> >> Spring may have had its reasons to detect hot plug events on a GPIO >> instead of using this pin, but that doesn't make this pin any less t= he >> "hot plug pin". >=20 > Please advise how to handle it then: Should there be two different > pinctrl entries (if so, how should it be named?),=20 IMHO this is the right way. Just name the GPIO variant dp_hpd_gpio. Best regards, Tomasz From mboxrd@z Thu Jan 1 00:00:00 1970 From: tomasz.figa@gmail.com (Tomasz Figa) Date: Fri, 01 Aug 2014 22:57:06 +0200 Subject: [PATCH v5 05/10] ARM: dts: Move dp_hpd from exynos5250 into smdk5250 and snow In-Reply-To: <53DBFE8A.7020505@suse.de> References: <1406868897-26874-1-git-send-email-afaerber@suse.de> <1406868897-26874-6-git-send-email-afaerber@suse.de> <53DBFE8A.7020505@suse.de> Message-ID: <53DBFF22.3010905@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 01.08.2014 22:54, Andreas F?rber wrote: > Doug, > > Am 01.08.2014 22:33, schrieb Doug Anderson: >> On Thu, Jul 31, 2014 at 9:54 PM, Andreas F?rber wrote: >>> Spring uses a different GPIO, so this is not a generic SoC piece. >>> >>> Suggested-by: Tomasz Figa >>> Signed-off-by: Andreas F?rber >>> --- >>> v5: New (Tomasz Figa) >>> Frees dp_hpd for Spring. >>> >>> arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 7 ------- >>> arch/arm/boot/dts/exynos5250-smdk5250.dts | 9 +++++++++ >>> arch/arm/boot/dts/exynos5250-snow.dts | 7 +++++++ >>> 3 files changed, 16 insertions(+), 7 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi >>> index 886cfca044ac..ed0e5230514b 100644 >>> --- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi >>> +++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi >>> @@ -581,13 +581,6 @@ >>> samsung,pin-pud = <0>; >>> samsung,pin-drv = <0>; >>> }; >>> - >>> - dp_hpd: dp_hpd { >>> - samsung,pins = "gpx0-7"; >>> - samsung,pin-function = <3>; >>> - samsung,pin-pud = <0>; >>> - samsung,pin-drv = <0>; >>> - }; >>> }; >>> >>> pinctrl at 13400000 { >>> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts >>> index aaa055ac0fe3..5d30fe1dcda4 100644 >>> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts >>> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts >>> @@ -414,3 +414,12 @@ >>> }; >>> }; >>> }; >>> + >>> +&pinctrl_0 { >>> + dp_hpd: dp_hpd { >>> + samsung,pins = "gpx0-7"; >>> + samsung,pin-function = <3>; >>> + samsung,pin-pud = <0>; >>> + samsung,pin-drv = <0>; >>> + }; >>> +}; >>> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts >>> index c4b0c73c736d..a9a2f2743794 100644 >>> --- a/arch/arm/boot/dts/exynos5250-snow.dts >>> +++ b/arch/arm/boot/dts/exynos5250-snow.dts >>> @@ -547,6 +547,13 @@ >>> }; >>> >>> &pinctrl_0 { >>> + dp_hpd: dp_hpd { >>> + samsung,pins = "gpx0-7"; >>> + samsung,pin-function = <3>; >>> + samsung,pin-pud = <0>; >>> + samsung,pin-drv = <0>; >>> + }; >>> + >> >> NAK. dp_hpd is a generic SoC piece. Pin function 0 and 1 are GPIOs. >> Pin function 3 is special function. This pin _is_ the hot plug detect >> pin for display port. When it's set as special function 3 it goes >> straight into the hot plug logic of the display port controller. >> >> Spring may have had its reasons to detect hot plug events on a GPIO >> instead of using this pin, but that doesn't make this pin any less the >> "hot plug pin". > > Please advise how to handle it then: Should there be two different > pinctrl entries (if so, how should it be named?), IMHO this is the right way. Just name the GPIO variant dp_hpd_gpio. Best regards, Tomasz