From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754621AbaHBK5H (ORCPT ); Sat, 2 Aug 2014 06:57:07 -0400 Received: from mailout2.zih.tu-dresden.de ([141.30.67.73]:36399 "EHLO mailout2.zih.tu-dresden.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753622AbaHBK5E (ORCPT ); Sat, 2 Aug 2014 06:57:04 -0400 Message-ID: <53DCC3F0.6000105@tu-dresden.de> Date: Sat, 02 Aug 2014 12:56:48 +0200 From: Thomas Ilsche User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Arnaldo Carvalho de Melo CC: Namhyung Kim , Peter Zijlstra , Ingo Molnar , Paul Mackerras , Namhyung Kim , LKML , Jiri Olsa , Thomas Ilsche Subject: Re: [PATCH v2 2/2] perf tools: Default to python version 2 References: <1406617040-26909-1-git-send-email-namhyung@kernel.org> <1406617040-26909-2-git-send-email-namhyung@kernel.org> <20140801202149.GB13375@kernel.org> In-Reply-To: <20140801202149.GB13375@kernel.org> Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha1; boundary="------------ms060009010700010502000605" X-TUD-Virus-Scanned: mailout2.zih.tu-dresden.de Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is a cryptographically signed message in MIME format. --------------ms060009010700010502000605 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Zitat von Arnaldo Carvalho de Melo : > Em Tue, Jul 29, 2014 at 03:57:20PM +0900, Namhyung Kim escreveu: >> According to PEP 394 recommendation [1], it's more portable to use >> python2 rather than plain python to refer python binary version 2. >> >> Since there're distros using python3 by default like Arch, and we >> don't support python3 (yet), it'd be better using python2 explicitly. >> >> But older versions (prior to 2.7) seem not to provide python2 but just= >> python. Given that it's only old version, try python2 first and then >> fallback to python. It'll ensure that it always points to python 2.x.= > > It should fallback, right? Yes. > [acme@fedora14 linux]$ ls -la /usr/bin/python2-config > ls: cannot access /usr/bin/python2-config: No such file or directory > [acme@fedora14 linux]$ ls -la /usr/bin/python-config > lrwxrwxrwx. 1 root root 16 Mar 25 09:43 /usr/bin/python-config -> =20 > python2.7-config Appearently this fedora package symlinks python -> python2 but does not s= o for python2-config. The Makefile looks for either python2 or python as fallba= ck and then assumes that a respective "-config" exists. I think this is a sane a= ssumption. I guess if this needs to be supported, there needs to be another fallback= if $(PYTHON)-config is not found to try python-config again. However this ma= y behave weirdly if someone has python2, no python2-devel but python3-devel= installed, sets PYTHON=3Dpython2 and then still gets a version error. Or = we somehow only fallback if no PYTHON is specified (not sure how to implemen= ted that elegantly). Best, Thomas > [acme@fedora14 linux]$ rpm -qf /usr/bin/python-config > python-devel-2.7-8.fc14.1.x86_64 > [acme@fedora14 linux]$ cat /etc/fedora-release > Fedora release 14 (Laughlin) > [acme@fedora14 linux]$ > > [acme@fedora14 linux]$ time make O=3D/tmp/build/perf -C tools/perf inst= all > make: Entering directory `/home/acme/git/linux/tools/perf' > BUILD: Doing 'make -j4' parallel build > config/Makefile:126: The path '/usr/bin/python2-config' is not executab= le. > config/Makefile:339: No libdw DWARF unwind found, Please install > elfutils-devel/libdw-dev >=3D 0.158 and/or set LIBDW_DIR > config/Makefile:481: Missing perl devel files. Disabling perl scripting= > support, consider installing perl-ExtUtils-Embed > config/Makefile:512: No python-config tool was found > config/Makefile:512: Python support will not be built > >> [1] https://www.python.org/dev/peps/pep-0394 >> >> Suggested-by: Thomas Ilsche >> Tested-by: Thomas Ilsche >> Signed-off-by: Namhyung Kim >> --- >> tools/perf/config/Makefile | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile >> index e05d8f99424d..60177278a357 100644 >> --- a/tools/perf/config/Makefile >> +++ b/tools/perf/config/Makefile >> @@ -121,8 +121,8 @@ ifdef PARSER_DEBUG >> endif >> >> ifndef NO_LIBPYTHON >> - override PYTHON :=3D \ >> - $(call get-executable-or-default,PYTHON,python) >> + PYTHON2 :=3D $(if $(call get-executable,python2),python2,python) >> + override PYTHON :=3D $(call get-executable-or-default,PYTHON,$(PYTH= ON2)) >> override PYTHON_CONFIG :=3D \ >> $(call get-executable-or-default,PYTHON_CONFIG,$(PYTHON)-config) >> >> -- >> 2.0.0 --------------ms060009010700010502000605 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIPhTCC BHQwggNcoAMCAQICCQCJkBEVWD6HmzANBgkqhkiG9w0BAQsFADBxMQswCQYDVQQGEwJERTEc MBoGA1UEChMTRGV1dHNjaGUgVGVsZWtvbSBBRzEfMB0GA1UECxMWVC1UZWxlU2VjIFRydXN0 IENlbnRlcjEjMCEGA1UEAxMaRGV1dHNjaGUgVGVsZWtvbSBSb290IENBIDIwHhcNMTQwMjEx MTMxMTQ1WhcNMTkwNzA5MjM1OTAwWjBaMQswCQYDVQQGEwJERTETMBEGA1UEChMKREZOLVZl cmVpbjEQMA4GA1UECxMHREZOLVBLSTEkMCIGA1UEAxMbREZOLVZlcmVpbiBQQ0EgR2xvYmFs IC0gRzAxMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA6ZvDZ4X5Da71jVTDllA1 PWLpbkztlNcAW5UidNQg6zSP1uzAMQQLmYHiphTSUqAoI4SLdIkEXlvg4njBeMsWyyg1OXst kEXQ7aAAeny/Sg4bAMOG6VwrMRF7DPOCJEOMHDiLamgAmu7cT3ir0sYTm3at7t4m6O8Br3QP wQmi9mvOvdPNFDBP9eXjpMhim4IaAycwDQJlYE3t0QkjKpY1WCfTdsZxtpAdxO3/NYZ9bzOz 2w/FEcKKg6GUXUFr2NIQ9Uz9ylGs2b3vkoO72uuLFlZWQ8/h1RM9ph8nMM1JVNvJEzSacXXF bOqnC5j5IZ0nrz6jOTlIaoytyZn7wxLyvQIDAQABo4IBJDCCASAwDgYDVR0PAQH/BAQDAgEG MB0GA1UdDgQWBBRJt8bP6D0ff+pEexMp9/EKcD7eZDAfBgNVHSMEGDAWgBQxw3kbuvVT1xfg iXotF2wKsyudMzASBgNVHRMBAf8ECDAGAQH/AgECMD8GA1UdHwQ4MDYwNKAyoDCGLmh0dHA6 Ly9vY3NwMDMzNi50ZWxlc2VjLmRlL3JsL0RUX1JPT1RfQ0FfMi5jcmwweQYIKwYBBQUHAQEE bTBrMCwGCCsGAQUFBzABhiBodHRwOi8vb2NzcDAzMzYudGVsZXNlYy5kZS9vY3NwcjA7Bggr BgEFBQcwAoYvaHR0cDovL29jc3AwMzM2LnRlbGVzZWMuZGUvY3J0L0RUX1JPT1RfQ0FfMi5j ZXIwDQYJKoZIhvcNAQELBQADggEBACwvqeBeQy8FcNxRlXVdgI47DMFjWFSBMIOcXalRh8m2 1w8runhIJGBCzPGi4jPhMh4ym1ETlXnGtazQJO0YFLwvKuovq7ITrEkdXgALBBhqmmXU6Ec1 vK7t33S22PGAUGWgxtojm41TR8psu0DJlV1OYHor5LtmQFWvtjPB6iMhbvxUnd0zQm5Ma9Xk w/LqBrdaMmoyRXS2tW/+6v8cY6q7iNH4WK8gfo+///b3OHeLGrZQP609R3lGw1e0F2KHvZ6j NiUHaCSqIvL2rynsN6UUma66AWCGdS1hFbp4loe1ks/hUJGeWToV7J5axob8KD5mutTZNa+t PEkihYfub48wggVhMIIESaADAgECAgcXpCR5aFyOMA0GCSqGSIb3DQEBCwUAMFoxCzAJBgNV BAYTAkRFMRMwEQYDVQQKEwpERk4tVmVyZWluMRAwDgYDVQQLEwdERk4tUEtJMSQwIgYDVQQD ExtERk4tVmVyZWluIFBDQSBHbG9iYWwgLSBHMDEwHhcNMTQwNTI3MTQ1MzI5WhcNMTkwNzA5 MjM1OTAwWjCBhTELMAkGA1UEBhMCREUxKDAmBgNVBAoTH1RlY2huaXNjaGUgVW5pdmVyc2l0 YWV0IERyZXNkZW4xDDAKBgNVBAsTA1pJSDEcMBoGA1UEAxMTVFUgRHJlc2RlbiBDQSAtIEcw MjEgMB4GCSqGSIb3DQEJARYRcGtpQHR1LWRyZXNkZW4uZGUwggEiMA0GCSqGSIb3DQEBAQUA A4IBDwAwggEKAoIBAQDBDh6T80T27NAn91B6YQsENBWT/LEfbGPagOzhM1w1Cjx3ICCilYCg JeIPQmBZT9RalxxF2z2OGDPcRTuqcaFPkgtdGaw1BFEIX+kGe3Itz2GlaKLPnQBHwcp+ODj8 OdgvD4wZqYkvsjaDx1ck2spHHVxLEh/7ybexJL3f1zatqPJkK2fJuOeeUz3Ip74sPqhKn3QA 5Q5E4JUHlvh3l4TDFrbmEIMntRqrJ+LaG2JCQ2G9hfEUvxeo3Zr6y88IdG+d7Hbp+XJkZYoO enVItm9z+atzo+NBxdmW8nD00xJAG52xQSwN4HR+qtj0CcnMtj41zXv6ul2E7ltRubqNM3sn AgMBAAGjggH+MIIB+jASBgNVHRMBAf8ECDAGAQH/AgEBMA4GA1UdDwEB/wQEAwIBBjARBgNV HSAECjAIMAYGBFUdIAAwHQYDVR0OBBYEFMUrU5MXg8n1RkLtQ2rftoCmR/LgMB8GA1UdIwQY MBaAFEm3xs/oPR9/6kR7Eyn38QpwPt5kMBwGA1UdEQQVMBOBEXBraUB0dS1kcmVzZGVuLmRl MIGIBgNVHR8EgYAwfjA9oDugOYY3aHR0cDovL2NkcDEucGNhLmRmbi5kZS9nbG9iYWwtcm9v dC1jYS9wdWIvY3JsL2NhY3JsLmNybDA9oDugOYY3aHR0cDovL2NkcDIucGNhLmRmbi5kZS9n bG9iYWwtcm9vdC1jYS9wdWIvY3JsL2NhY3JsLmNybDCB1wYIKwYBBQUHAQEEgcowgccwMwYI KwYBBQUHMAGGJ2h0dHA6Ly9vY3NwLnBjYS5kZm4uZGUvT0NTUC1TZXJ2ZXIvT0NTUDBHBggr BgEFBQcwAoY7aHR0cDovL2NkcDEucGNhLmRmbi5kZS9nbG9iYWwtcm9vdC1jYS9wdWIvY2Fj ZXJ0L2NhY2VydC5jcnQwRwYIKwYBBQUHMAKGO2h0dHA6Ly9jZHAyLnBjYS5kZm4uZGUvZ2xv YmFsLXJvb3QtY2EvcHViL2NhY2VydC9jYWNlcnQuY3J0MA0GCSqGSIb3DQEBCwUAA4IBAQCJ hMBD4Oh4PXhRwECrWgomDDnELDDFh4FN1e2g0gYbKLg/kA0gw6RKImh4GhTRAbENxW2My+tH aKFjtwQdBaanilk4DN581jqxjo37jPEwDmNNzT8U4ssiwmkMD2bWM2vTcc7lDj2g7w+sRzIJ 8zi1AtCV43bJT8xBVj0PQpFuqYVvYzgMq+KNtGn4YyiBAMyDY1EzPEgtOovN7sqXb3jGDa71 gqdHWIKf9orfDWCZ/Y8d+Y+rSqtBAHj0fnAzjnIgtJvUIif+Afx/4Rvxy0MHj3q6uHhPFcZ9 QBPm+vxX2nWXEMlJcf1A/Igdah5hUpkmAQIUUJso8QbE4gXBS/BPMIIFpDCCBIygAwIBAgIH FyxZ1i7USDANBgkqhkiG9w0BAQUFADCBhTELMAkGA1UEBhMCREUxKDAmBgNVBAoTH1RlY2hu aXNjaGUgVW5pdmVyc2l0YWV0IERyZXNkZW4xDDAKBgNVBAsTA1pJSDEcMBoGA1UEAxMTVFUg RHJlc2RlbiBDQSAtIEcwMjEgMB4GCSqGSIb3DQEJARYRcGtpQHR1LWRyZXNkZW4uZGUwHhcN MTQwMjI1MTgwOTExWhcNMTcwMjI0MTgwOTExWjBdMQswCQYDVQQGEwJERTEoMCYGA1UEChMf VGVjaG5pc2NoZSBVbml2ZXJzaXRhZXQgRHJlc2RlbjEMMAoGA1UECxMDWklIMRYwFAYDVQQD Ew1UaG9tYXMgSWxzY2hlMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAzxoc9lcS 97ONeAVS1Y361WCBX3sCjHlopnPOgLGsscTI3jd75BxiAeSCvFwu9POGs2vsIHeiKKQyu+3F s3QHKbewYH/E9D5dcJ8VtKFBL0jU7NaXm8jLY/0nPOOX1t8OGdykV1Hio7KH5RyyOX/XZ6cs DNRFNACcOMyMTHuSIcMX4htxPmiLsNBXTQ0Ohf/7WClIRIXxYO0EMMA/4Fb3WC23YdPSedJr RRU/cs0nKcV4g6O14ZfvzN3hQFqs06TBhde3Mv+yUyKHalaOoggNlBqjRXh6KyCYDZnou6Bm S1EQs+UchWU6jo8WXaKbadJpaIxL3HtcV5JFHZOibtmzJQIDAQABo4ICPjCCAjowLwYDVR0g BCgwJjARBg8rBgEEAYGtIYIsAQEEAwEwEQYPKwYBBAGBrSGCLAIBBAMBMAkGA1UdEwQCMAAw CwYDVR0PBAQDAgXgMB0GA1UdJQQWMBQGCCsGAQUFBwMCBggrBgEFBQcDBDAdBgNVHQ4EFgQU tl3TKO1q/IByitqlWh99jrj7AagwHwYDVR0jBBgwFoAUxStTkxeDyfVGQu1Dat+2gKZH8uAw JgYDVR0RBB8wHYEbdGhvbWFzLmlsc2NoZUB0dS1kcmVzZGVuLmRlMIGLBgNVHR8EgYMwgYAw PqA8oDqGOGh0dHA6Ly9jZHAxLnBjYS5kZm4uZGUvdHUtZHJlc2Rlbi1jYS9wdWIvY3JsL2df Y2FjcmwuY3JsMD6gPKA6hjhodHRwOi8vY2RwMi5wY2EuZGZuLmRlL3R1LWRyZXNkZW4tY2Ev cHViL2NybC9nX2NhY3JsLmNybDCB2QYIKwYBBQUHAQEEgcwwgckwMwYIKwYBBQUHMAGGJ2h0 dHA6Ly9vY3NwLnBjYS5kZm4uZGUvT0NTUC1TZXJ2ZXIvT0NTUDBIBggrBgEFBQcwAoY8aHR0 cDovL2NkcDEucGNhLmRmbi5kZS90dS1kcmVzZGVuLWNhL3B1Yi9jYWNlcnQvZ19jYWNlcnQu Y3J0MEgGCCsGAQUFBzAChjxodHRwOi8vY2RwMi5wY2EuZGZuLmRlL3R1LWRyZXNkZW4tY2Ev cHViL2NhY2VydC9nX2NhY2VydC5jcnQwDQYJKoZIhvcNAQEFBQADggEBADkeZ80dWsjpjOkn /Rk/1nBWHj139rRsPNCrwr2CZLHLiO9pB6SYTx9W5/7v5hg8883E9ProF/h+nhKiaLtNxsBw jx8a1v8Uz4buJSeYsFs0wEl3sOoCsfwVNjgJ++AcYu8zsOaalIzeBc4dOiP7gMyN6vyODX3H HJSySzuffl+ywGQCJWcsjNrOnrRYw99vmKcLB9aI728AMNr/ugJcIGcEfu6ABtECHDhsgYKS iS+KElT7Yqak4Up7Ji+Q03l4r0s6e9NjT+nScN5ap8g30j0PRWdsQ/fxpM5cwP8nP3if7i5p 3Qy5GEnIEusfkLFckPVLJhRYtL1+kJOVsUs+S4gxggPUMIID0AIBATCBkTCBhTELMAkGA1UE BhMCREUxKDAmBgNVBAoTH1RlY2huaXNjaGUgVW5pdmVyc2l0YWV0IERyZXNkZW4xDDAKBgNV BAsTA1pJSDEcMBoGA1UEAxMTVFUgRHJlc2RlbiBDQSAtIEcwMjEgMB4GCSqGSIb3DQEJARYR cGtpQHR1LWRyZXNkZW4uZGUCBxcsWdYu1EgwCQYFKw4DAhoFAKCCAhcwGAYJKoZIhvcNAQkD MQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMTQwODAyMTA1NjQ4WjAjBgkqhkiG9w0B CQQxFgQU7z5yLqyktDYv7m/Jo28ikiGAVXswbAYJKoZIhvcNAQkPMV8wXTALBglghkgBZQME ASowCwYJYIZIAWUDBAECMAoGCCqGSIb3DQMHMA4GCCqGSIb3DQMCAgIAgDANBggqhkiG9w0D AgIBQDAHBgUrDgMCBzANBggqhkiG9w0DAgIBKDCBogYJKwYBBAGCNxAEMYGUMIGRMIGFMQsw CQYDVQQGEwJERTEoMCYGA1UEChMfVGVjaG5pc2NoZSBVbml2ZXJzaXRhZXQgRHJlc2RlbjEM MAoGA1UECxMDWklIMRwwGgYDVQQDExNUVSBEcmVzZGVuIENBIC0gRzAyMSAwHgYJKoZIhvcN AQkBFhFwa2lAdHUtZHJlc2Rlbi5kZQIHFyxZ1i7USDCBpAYLKoZIhvcNAQkQAgsxgZSggZEw gYUxCzAJBgNVBAYTAkRFMSgwJgYDVQQKEx9UZWNobmlzY2hlIFVuaXZlcnNpdGFldCBEcmVz ZGVuMQwwCgYDVQQLEwNaSUgxHDAaBgNVBAMTE1RVIERyZXNkZW4gQ0EgLSBHMDIxIDAeBgkq hkiG9w0BCQEWEXBraUB0dS1kcmVzZGVuLmRlAgcXLFnWLtRIMA0GCSqGSIb3DQEBAQUABIIB AJZFkdH5DyjSeqeWPbJeNXcQs74OdhAQMwshLwKDjISrpt4u6BAYdFpFMrW38zBtq6O8dFaq Nb1Kwg0LVM3FUER7ds/fz+TMCxJ1Mhf+HjPwU7sUDlEhKmFWYWyz4aC7zZ8/dksfVpkT/ZAU wLMwvTbsKbRFGi/wiMkFX/WKbUr0WIXyivaHp8hdwdY9rh6TTYLkhKEFm0WUkfDnold8lU62 pAoVDtGZfqSM1wR8q7sFMxJFkUQbvZXPUHem6bsG16nk9a5ZmP6SQeO58bFal7H6SAykAYfP Z/mJ6WIRvsencjl9Tdo8/3ADLh5uOuMvcQyYkZ127q+z9hb91z95JxcAAAAAAAA= --------------ms060009010700010502000605--