From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49620) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XDZPK-0002gY-8e for qemu-devel@nongnu.org; Sat, 02 Aug 2014 09:31:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XDZPE-0005Kj-3I for qemu-devel@nongnu.org; Sat, 02 Aug 2014 09:31:34 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:45537) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XDZPD-0005Kd-Qz for qemu-devel@nongnu.org; Sat, 02 Aug 2014 09:31:27 -0400 Message-ID: <53DCE82E.1050106@msgid.tls.msk.ru> Date: Sat, 02 Aug 2014 17:31:26 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1404760407-1554-1-git-send-email-sw@weilnetz.de> In-Reply-To: <1404760407-1554-1-git-send-email-sw@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] virtio: Move extern declaration to header file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil , qemu-devel@nongnu.org Cc: Nikolay Nikolaev 07.07.2014 23:13, Stefan Weil wrote: [] > index 35316c4..ff4f200 100644 > --- a/hw/virtio/vhost-backend.c > +++ b/hw/virtio/vhost-backend.c > @@ -14,8 +14,6 @@ > > #include > > -extern const VhostOps user_ops; > - BTW, it looks like we still have just one VhostOps - this user_ops one - despite commit 24d1eb33eb2ccd995a which was aimed to add another ops (kernel) back in May. Maybe we should not add extra indirection without a reason, before it is actually used? Also, "user_ops" is way too generic name. Maybe user_vhost_ops or something. Just.. saying. Thanks, /mjt