From: Kinglong Mee <kinglongmee@gmail.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
NeilBrown <neilb@suse.de>,
jlayton@redhat.com,
Trond Myklebust <trond.myklebust@primarydata.com>,
linux-fsdevel@vger.kernel.org
Subject: [PATCH] fs/locks.c: Copy fl_lmops to conflock for nfsd using
Date: Sat, 02 Aug 2014 22:45:17 +0800 [thread overview]
Message-ID: <53DCF97D.3000605@gmail.com> (raw)
In-Reply-To: <53BAAAC5.9000106@gmail.com>
Commit d5b9026a67 ([PATCH] knfsd: locks: flag NFSv4-owned locks)
using fl_lmops field in file_lock for checking nfsd4 lockowner.
But, commit 1a747ee0cc (locks: don't call ->copy_lock methods
on return of conflicting locks) causes the fl_lmops of conflock
for nfsd4_lock always be NULL.
Also, commit 0996905f93 (lockd: posix_test_lock() should not call
locks_copy_lock()) caused the fl_lmops of conflock for nfsd4_lockt
always be NULL too.
So that, nfsd4 lockowner for it always be NULL too.
This patch re-coping the fl_lmops to conflock.
Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
---
fs/locks.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index 717fbc4..cc1219a 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -279,7 +279,7 @@ void __locks_copy_lock(struct file_lock *new, const struct file_lock *fl)
new->fl_start = fl->fl_start;
new->fl_end = fl->fl_end;
new->fl_ops = NULL;
- new->fl_lmops = NULL;
+ new->fl_lmops = fl->fl_lmops;
}
EXPORT_SYMBOL(__locks_copy_lock);
@@ -290,7 +290,6 @@ void locks_copy_lock(struct file_lock *new, struct file_lock *fl)
__locks_copy_lock(new, fl);
new->fl_file = fl->fl_file;
new->fl_ops = fl->fl_ops;
- new->fl_lmops = fl->fl_lmops;
locks_copy_private(new, fl);
}
--
1.9.3
next prev parent reply other threads:[~2014-08-02 14:45 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 14:12 [PATCH 2/4] NFSD: Rervert "knfsd: locks: flag NFSv4-owned locks" Kinglong Mee
2014-07-07 16:45 ` Jeff Layton
2014-07-08 2:30 ` Kinglong Mee
2014-07-07 17:26 ` Jeff Layton
2014-07-08 3:23 ` Kinglong Mee
2014-07-08 11:03 ` Jeff Layton
2014-07-08 12:26 ` Kinglong Mee
2014-07-08 12:39 ` Jeff Layton
2014-07-11 22:11 ` J. Bruce Fields
2014-08-02 14:45 ` Kinglong Mee [this message]
2014-08-02 14:59 ` [PATCH] fs/locks.c: Copy fl_lmops to conflock for nfsd using Trond Myklebust
2014-08-02 23:05 ` Jeff Layton
2014-08-02 23:05 ` Jeff Layton
2014-08-05 19:14 ` J. Bruce Fields
2014-08-05 19:14 ` J. Bruce Fields
2014-08-05 19:20 ` Jeff Layton
2014-08-05 19:20 ` Jeff Layton
2014-08-06 13:33 ` [PATCH 1/3] NFSD: New FL_NFSD for marking file_lock belongs to NFSD Kinglong Mee
2014-08-06 13:33 ` Kinglong Mee
2014-08-06 13:35 ` [PATCH 2/3] NFSD: Increase the reference of lockowner when coping file_lock Kinglong Mee
2014-08-06 13:35 ` Kinglong Mee
2014-08-06 13:38 ` [PATCH 3/3 RFC] fs/locks.c: Copy all infomation for conflock Kinglong Mee
2014-08-06 13:38 ` Kinglong Mee
2014-08-09 11:08 ` [PATCH 2/3] NFSD: Increase the reference of lockowner when coping file_lock Jeff Layton
2014-08-09 11:08 ` Jeff Layton
2014-08-10 15:47 ` Kinglong Mee
2014-08-10 15:47 ` Kinglong Mee
2014-08-09 10:51 ` [PATCH 1/3] NFSD: New FL_NFSD for marking file_lock belongs to NFSD Jeff Layton
2014-08-10 12:46 ` Kinglong Mee
2014-08-10 12:46 ` Kinglong Mee
2014-08-10 15:38 ` [PATCH 1/3 v2] fs/locks.c: Copy all information for conflock Kinglong Mee
2014-08-10 15:38 ` Kinglong Mee
2014-08-10 15:42 ` [PATCH 2/3 v2] fs/locks.c: New ops in file_lock_operations for copying/releasing owner Kinglong Mee
2014-08-10 15:42 ` Kinglong Mee
2014-08-10 15:43 ` [PATCH 3/3 v2] NFSD: Increase the reference of lockowner when coping file_lock Kinglong Mee
2014-08-10 15:43 ` Kinglong Mee
2014-08-11 16:46 ` Jeff Layton
2014-08-11 16:46 ` Jeff Layton
2014-08-14 12:30 ` Kinglong Mee
2014-08-14 12:30 ` Kinglong Mee
2014-08-11 16:19 ` [PATCH 1/3 v2] fs/locks.c: Copy all information for conflock Jeff Layton
2014-08-11 16:19 ` Jeff Layton
2014-08-11 16:25 ` Joe Perches
2014-08-11 16:25 ` Joe Perches
2014-08-14 12:59 ` Kinglong Mee
2014-08-14 12:59 ` Kinglong Mee
2014-08-14 12:26 ` Kinglong Mee
2014-08-14 12:26 ` Kinglong Mee
2014-08-14 14:00 ` Jeff Layton
2014-08-14 14:04 ` Kinglong Mee
2014-08-14 14:04 ` Kinglong Mee
2014-08-15 0:02 ` [PATCH 1/5 v3] NFSD: Remove duplicate initialization of file_lock Kinglong Mee
2014-08-15 0:02 ` Kinglong Mee
2014-08-15 10:57 ` Jeff Layton
2014-08-15 10:57 ` Jeff Layton
2014-08-15 21:35 ` J. Bruce Fields
2014-08-15 21:35 ` J. Bruce Fields
2014-08-15 0:07 ` [PATCH 2/5 v3] locks: Copy all infomation for conflock Kinglong Mee
2014-08-15 11:14 ` Jeff Layton
2014-08-15 11:14 ` Jeff Layton
2014-08-15 14:33 ` Kinglong Mee
2014-08-15 14:33 ` Kinglong Mee
2014-08-16 13:35 ` Kinglong Mee
2014-08-16 13:35 ` Kinglong Mee
2014-08-17 13:42 ` Kinglong Mee
2014-08-17 13:42 ` Kinglong Mee
2014-08-18 11:54 ` Jeff Layton
2014-08-18 11:54 ` Jeff Layton
2014-08-19 15:10 ` Kinglong Mee
2014-08-15 0:09 ` [PATCH 3/5 v3] locks: New ops in file_lock_operations for copy/release owner Kinglong Mee
2014-08-15 0:09 ` Kinglong Mee
2014-08-15 0:10 ` [PATCH 4/5 v3] NFSD: New helper nfs4_get_stateowner() for atomic_inc reference Kinglong Mee
2014-08-15 0:13 ` [PATCH 5/5 v3] NFSD: Increase the reference of lockowner when coping file_lock Kinglong Mee
2014-08-15 0:13 ` Kinglong Mee
2014-08-19 15:16 ` [PATCH 1/6 v4] NFSD: Remove the duplicate initialize of file_lock Kinglong Mee
2014-08-19 15:16 ` Kinglong Mee
2014-08-19 15:18 ` [PATCH 2/6 v4] locks: New ops in file_lock_operations for get/put owner Kinglong Mee
2014-08-19 19:42 ` Jeff Layton
2014-08-19 19:42 ` Jeff Layton
2014-08-19 15:21 ` [PATCH 3/6 v4] locks: Rename __locks_copy_lock() to locks_copy_conflock() Kinglong Mee
2014-08-19 19:46 ` Jeff Layton
2014-08-19 15:24 ` [PATCH 4/6 v4] locks: Copy fl_lmops information for conflock in, locks_copy_conflock() Kinglong Mee
2014-08-19 15:24 ` Kinglong Mee
2014-08-19 20:08 ` Jeff Layton
2014-08-19 15:25 ` [PATCH 5/6 v4] NFSD: New helper nfs4_get_stateowner() for atomic_inc sop reference Kinglong Mee
2014-08-19 20:14 ` Jeff Layton
2014-08-19 15:26 ` [PATCH 6/6 v4] NFSD: Increase the reference of lockowner when coping file_lock Kinglong Mee
2014-08-19 20:23 ` Jeff Layton
2014-08-19 20:23 ` Jeff Layton
2014-08-19 20:24 ` J. Bruce Fields
2014-08-20 10:02 ` Kinglong Mee
2014-08-20 10:02 ` Kinglong Mee
2014-08-20 9:51 ` [PATCH 1/6 v5] NFSD: Remove the duplicate initialize of file_lock Kinglong Mee
2014-08-20 9:53 ` [PATCH 2/6 v5] locks: Rename __locks_copy_lock() to locks_copy_conflock() Kinglong Mee
2014-08-20 9:53 ` Kinglong Mee
2014-08-20 9:54 ` [PATCH 3/6 v5] locks: New ops in file_lock_operations for get/put owner Kinglong Mee
2014-08-20 9:54 ` Kinglong Mee
2014-08-20 9:56 ` [PATCH 4/6 v5] locks: Copy fl_lmops information for conflock in locks_copy_conflock() Kinglong Mee
2014-08-20 9:57 ` [PATCH 5/6 v5] NFSD: New helper nfs4_get_stateowner() for atomic_inc sop reference Kinglong Mee
2014-08-20 9:57 ` Kinglong Mee
2014-08-20 9:59 ` [PATCH 6/6 v5] NFSD: Get reference of lockowner when coping file_lock Kinglong Mee
2014-08-20 9:59 ` Kinglong Mee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DCF97D.3000605@gmail.com \
--to=kinglongmee@gmail.com \
--cc=bfields@fieldses.org \
--cc=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.