From: Jonathan Cameron <jic23@kernel.org>
To: Teodora Baluta <teodora.baluta@intel.com>, linux-iio@vger.kernel.org
Subject: Re: [PATCH 4/5] staging: iio: isl29018: fix sparse warning regarding incorrect type (different signedness)
Date: Sat, 02 Aug 2014 17:35:52 +0100 [thread overview]
Message-ID: <53DD1368.8080008@kernel.org> (raw)
In-Reply-To: <1406546313-23031-5-git-send-email-teodora.baluta@intel.com>
On 28/07/14 12:18, Teodora Baluta wrote:
> Fix the following sparse warning:
>
> drivers/staging/iio/light/isl29018.c:508:50: warning: incorrect type in
> argument 3 (different signedness)
> drivers/staging/iio/light/isl29018.c:508:50: expected unsigned int
> *conf_adc_bit
> drivers/staging/iio/light/isl29018.c:508:50: got int *<noident>
>
> Signed-off-by: Teodora Baluta <teodora.baluta@intel.com>
Applied to the togreg branch of iio.git initially pushed out as testing
for the autobuilders to play.
J
> ---
> drivers/staging/iio/light/isl29018.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c
> index 3660a43..86cc8f9 100644
> --- a/drivers/staging/iio/light/isl29018.c
> +++ b/drivers/staging/iio/light/isl29018.c
> @@ -454,7 +454,7 @@ static const struct attribute_group isl29108_group = {
> static int isl29018_chip_init(struct isl29018_chip *chip)
> {
> int status;
> - int new_adc_bit;
> + unsigned int new_adc_bit;
> unsigned int new_range;
>
> /* Code added per Intersil Application Note 1534:
>
next prev parent reply other threads:[~2014-08-02 16:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 11:18 [PATCH 0/5] staging: iio: minor fixes for sparse warnings Teodora Baluta
2014-07-28 11:18 ` [PATCH 1/5] staging: iio: ad7816: fix sparse warning cast to restricted __be16 Teodora Baluta
2014-08-02 11:56 ` Jonathan Cameron
2014-07-28 11:18 ` [PATCH 2/5] staging: iio: ad5933: " Teodora Baluta
2014-08-02 11:57 ` Jonathan Cameron
2014-07-28 11:18 ` [PATCH 3/5] staging: iio: hmc5843_core: fix sparse warnings Teodora Baluta
2014-08-02 16:33 ` Jonathan Cameron
2014-07-28 11:18 ` [PATCH 4/5] staging: iio: isl29018: fix sparse warning regarding incorrect type (different signedness) Teodora Baluta
2014-08-02 16:35 ` Jonathan Cameron [this message]
2014-07-28 11:18 ` [PATCH 5/5] staging: iio: adis16240: fix sparse warnings regarding incorrect argument type Teodora Baluta
2014-08-02 16:44 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DD1368.8080008@kernel.org \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=teodora.baluta@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.