From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f49.google.com (mail-pa0-f49.google.com [209.85.220.49]) by kanga.kvack.org (Postfix) with ESMTP id C9F7E6B0036 for ; Sat, 2 Aug 2014 14:54:55 -0400 (EDT) Received: by mail-pa0-f49.google.com with SMTP id hz1so7668024pad.36 for ; Sat, 02 Aug 2014 11:54:55 -0700 (PDT) Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2lp0205.outbound.protection.outlook.com. [207.46.163.205]) by mx.google.com with ESMTPS id cn5si2345998pbb.28.2014.08.02.11.54.54 for (version=TLSv1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 02 Aug 2014 11:54:54 -0700 (PDT) Message-ID: <53DD33DE.7090401@amd.com> Date: Sat, 2 Aug 2014 21:54:22 +0300 From: Oded Gabbay MIME-Version: 1.0 Subject: Re: [PATCH 1/7] mmu_notifier: add call_srcu and sync function for listener to delay call and sync. References: <1405622809-3797-1-git-send-email-j.glisse@gmail.com> <1405622809-3797-2-git-send-email-j.glisse@gmail.com> <53CD2B43.3090405@amd.com> <53D7B800.6050700@amd.com> <20140729134803.8db34d88eda9209bda6069c7@linux-foundation.org> In-Reply-To: <20140729134803.8db34d88eda9209bda6069c7@linux-foundation.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, j.glisse@gmail.com, Linus Torvalds , joro@8bytes.org, Mel Gorman , "H. Peter Anvin" , Peter Zijlstra , Andrea Arcangeli , Johannes Weiner , Larry Woodman , Rik van Riel , Dave Airlie , Brendan Conoboy , Joe Donohue , Duncan Poole , Sherry Cheung , Subhash Gutti , John Hubbard , Mark Hairgrove , Lucien Dunning , Cameron Buschardt , Arvind Gopalakrishnan , Shachar Raindel , Liran Liss , Roland Dreier , Ben Sander , Greg Stoner , John Bridgman , Michael Mantor , Paul Blinzer , Laurent Morichetti , Alexander Deucher , =?UTF-8?B?SsOpcsO0bWUgR2xp?= =?UTF-8?B?c3Nl?= Hi Andrew, I re-submitted the patch today with a more detailed explanation about the problem and the proposed solution. I would like to add that I tested this solution with iommuv2 driver and with AMD's amdkfd driver (which we currently try to upstream). If you could merge it for 3.17-rc1 as you said, that would be great. Oded On 29/07/14 23:48, Andrew Morton wrote: > On Tue, 29 Jul 2014 18:04:32 +0300 Oded Gabbay wrote: > >> On 21/07/14 18:01, Oded Gabbay wrote: >>> On 17/07/14 21:46, j.glisse@gmail.com wrote: >>>> From: Peter Zijlstra >>>> >>>> New mmu_notifier listener are eager to cleanup there structure after the >>>> mmu_notifier::release callback. In order to allow this the patch provide >>>> a function that allows to add a delayed call to the mmu_notifier srcu. It >>>> also add a function that will call barrier_srcu so those listener can sync >>>> with mmu_notifier. >>> >>> Tested with amdkfd and iommuv2 driver >>> So, >>> Tested-by: Oded Gabbay >> >> akpm, any chance that only this specific patch from Peter.Z will get in 3.17 ? >> I must have it for amdkfd (HSA driver). Without it, I can't be in 3.17 either. > > I can send it in for 3.17-rc1. > > Can we get a better changelog please? "eager to cleanup there > structure after the mmu_notifier::release callback" is terribly vague > and brief. Fully describe the problem then describe the proposed > solution. Because others may be able to suggest alternative ways of > solving that problem, but this text simply doesn't provide enough details for > them to do so. > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org