From: sashal@kernel.org (Sasha Levin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: PCI: Use PCI_CLASS_* defines for PCI class
Date: Sun, 03 Aug 2014 09:16:25 -0400 [thread overview]
Message-ID: <53DE3629.2020706@kernel.org> (raw)
In-Reply-To: <1406904671-19197-1-git-send-email-lisovy@gmail.com>
On 08/01/2014 10:51 AM, Rostislav Lisovy wrote:
> Signed-off-by: Rostislav Lisovy <lisovy@gmail.com>
> ---
> arch/arm/kernel/bios32.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/kernel/bios32.c b/arch/arm/kernel/bios32.c
> index 17a26c1..e511ad1 100644
> --- a/arch/arm/kernel/bios32.c
> +++ b/arch/arm/kernel/bios32.c
> @@ -255,10 +255,9 @@ static void pci_fixup_it8152(struct pci_dev *dev)
> {
> int i;
> /* fixup for ITE 8152 devices */
> - /* FIXME: add defines for class 0x68000 and 0x80103 */
> if ((dev->class >> 8) == PCI_CLASS_BRIDGE_HOST ||
> - dev->class == 0x68000 ||
> - dev->class == 0x80103) {
> + dev->class == (PCI_CLASS_BRIDGE_OTHER << 8) ||
> + dev->class == ((PCI_CLASS_SYSTEM_DMA << 8) | 0x03)) {
> for (i = 0; i < PCI_NUM_RESOURCES; i++) {
> dev->resource[i].start = 0;
> dev->resource[i].end = 0;
>
Care to explain how your new code is equivalent to the old one?
Thanks,
Sasha
WARNING: multiple messages have this Message-ID (diff)
From: Sasha Levin <sashal@kernel.org>
To: Rostislav Lisovy <lisovy@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Bjorn Helgaas <bhelgaas@google.com>,
Yijing Wang <wangyijing@huawei.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: Nicholas Krause <xerofoify@gmail.com>
Subject: Re: [PATCH] ARM: PCI: Use PCI_CLASS_* defines for PCI class
Date: Sun, 03 Aug 2014 09:16:25 -0400 [thread overview]
Message-ID: <53DE3629.2020706@kernel.org> (raw)
In-Reply-To: <1406904671-19197-1-git-send-email-lisovy@gmail.com>
On 08/01/2014 10:51 AM, Rostislav Lisovy wrote:
> Signed-off-by: Rostislav Lisovy <lisovy@gmail.com>
> ---
> arch/arm/kernel/bios32.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/kernel/bios32.c b/arch/arm/kernel/bios32.c
> index 17a26c1..e511ad1 100644
> --- a/arch/arm/kernel/bios32.c
> +++ b/arch/arm/kernel/bios32.c
> @@ -255,10 +255,9 @@ static void pci_fixup_it8152(struct pci_dev *dev)
> {
> int i;
> /* fixup for ITE 8152 devices */
> - /* FIXME: add defines for class 0x68000 and 0x80103 */
> if ((dev->class >> 8) == PCI_CLASS_BRIDGE_HOST ||
> - dev->class == 0x68000 ||
> - dev->class == 0x80103) {
> + dev->class == (PCI_CLASS_BRIDGE_OTHER << 8) ||
> + dev->class == ((PCI_CLASS_SYSTEM_DMA << 8) | 0x03)) {
> for (i = 0; i < PCI_NUM_RESOURCES; i++) {
> dev->resource[i].start = 0;
> dev->resource[i].end = 0;
>
Care to explain how your new code is equivalent to the old one?
Thanks,
Sasha
next prev parent reply other threads:[~2014-08-03 13:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 14:51 [PATCH] ARM: PCI: Use PCI_CLASS_* defines for PCI class Rostislav Lisovy
2014-08-01 14:51 ` Rostislav Lisovy
2014-08-03 13:16 ` Sasha Levin [this message]
2014-08-03 13:16 ` Sasha Levin
2014-08-04 9:31 ` Rostislav Lisovy
2014-08-04 9:31 ` Rostislav Lisovy
2014-08-25 8:39 ` Rostislav Lisovy
2014-08-25 8:39 ` Rostislav Lisovy
2014-08-25 9:02 ` Yijing Wang
2014-08-25 9:02 ` Yijing Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DE3629.2020706@kernel.org \
--to=sashal@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.