Re: [PATCH 3/4] Add the "verbose" module option.

[Goffredo Baroncelli <kreijack@gmail.com>]

On 08/03/2014 05:52 PM, Jean Delvare wrote:
> On Sun, 03 Aug 2014 17:12:57 +0200, Goffredo Baroncelli wrote:
>> On 08/03/2014 04:12 PM, Jean Delvare wrote:
>>>> +	    (verbose > 0 && level >= 0)) {
>>>> +		print_temp("CPU-temp: ", temp );
>>>> +		if (casetemp)
>>>> +			print_temp(", Case: ", casetemp );
>>>> +		if (level >= 0)
>>>> +			printk(", Fan: %d (tuned %+d)\n", 11-level,
>>>> +				x.fan_level-level );
>>>> +		else
>>>> +			printk(", Fan: %d (tuned +0)\n",x.fan_level);
>>>
>>> I think you can do without the "tuned +0" which doesn't add much value.
>>
>> Me too. But the old driver does the same, so I preferred to 
>> leave it as is.
> 
> I looked at the code again and no, I can't see the old code doing that.
> It has "tuned %+d" only in tune_fan() which is only called if
> level >= 0. The other printk (when tune_fan isn't called) doesn't have
> a "tuned" part.
> 

This is taken from an old log of a v3.2 kernel (no changes here):

[  886.510879] CPU-temp: 55.4 C, Case: 33.1 C,  Fan: 0 (tuned -11)
[  910.522869] CPU-temp: 56.0 C, Case: 33.5 C,  Fan: 0 (tuned +0)
[  958.546880] CPU-temp: 57.0 C, Case: 34.1 C,  Fan: 3 (tuned +3)

in the code if level <0, then there is no update in the log. But if
level >0 and level is equal to the previous one, this leads to
have "tuned +0"...

But I have to be honest: I have not fully understand how 
"level" is computed.

The printk without "(tuned %+d)" is never called because 
LOG_TEMP was #define(d) equal to 0.




-- 
gpg @keyserver.linux.it: Goffredo Baroncelli (kreijackATinwind.it>
Key fingerprint BBF5 1610 0B64 DAC6 5F7D  17B2 0EDA 9B37 8B82 E0B5