Re: [PATCH 1/2] usb: renesas_usbhs: Add device tree bindings documentation

[Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>]

Hello,

(2014/08/01 22:35), Sergei Shtylyov wrote:
> Hello.
> 
> On 08/01/2014 03:49 PM, Yoshihiro Shimoda wrote:
> 
>> Document the device tree bindings for the Renesas USBHS controller.
> 
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>> ---
>>   .../devicetree/bindings/usb/renesas_usbhs.txt      |   24 ++++++++++++++++++++
>>   1 file changed, 24 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> 
>> diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
>> new file mode 100644
>> index 0000000..e9faa65
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
>> @@ -0,0 +1,24 @@
>> +Renesas Electronics USBHS driver
>> +
>> +Required properties:
>> +  - compatible: Must contain one of the following:
>> +	- "renesas,usbhs-r8a7790"
>> +	- "renesas,usbhs-r8a7791"
>> +  - reg: Base address and length of the register for the USBHS
>> +  - interrupts: Interrupt specifier for the USBHS
>> +  - clocks: A list of phandle + clock specifier pairs
>> +
>> +Optional properties:
>> +  - buswait_bwait: Integer to use BUSWAIT register
> 
>    Should be named "renesas,buswait-bwait" or probably just "renesas,buswait".

Thank you for the point. I will fix this name to "renesas,buswait".

>> +  - enable-gpio: A gpio specifier to check GPIO determining if USB function
> 
>    Should also be prefixed with "renesas,".

I will fix this name to "renesas,enable-gpio".

Best regards,
Yoshihiro Shimoda

> [...]
> 
> WBR, Sergei
>