All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bo Shen <voice.shen@atmel.com>
To: "Raphaël Poggi" <poggi.raph@gmail.com>, barebox@lists.infradead.org
Subject: Re: [PATCH V2 2/2] at91sam9g45: clock: add i2c clocks
Date: Mon, 4 Aug 2014 17:17:18 +0800	[thread overview]
Message-ID: <53DF4F9E.2070901@atmel.com> (raw)
In-Reply-To: <1407141112-3868-3-git-send-email-poggi.raph@gmail.com>

Hi Raphaël Poggi,

On 08/04/2014 04:31 PM, Raphaël Poggi wrote:
> Add the device tree and non device tree at91 i2c clocks.
>
> Signed-off-by: Raphaël Poggi <poggi.raph@gmail.com>
> ---
>   arch/arm/mach-at91/at91sam9g45.c |    4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/mach-at91/at91sam9g45.c b/arch/arm/mach-at91/at91sam9g45.c
> index f6031f0..d0f950c 100644
> --- a/arch/arm/mach-at91/at91sam9g45.c
> +++ b/arch/arm/mach-at91/at91sam9g45.c
> @@ -192,6 +192,10 @@ static struct clk_lookup periph_clocks_lookups[] = {
>   	CLKDEV_CON_DEV_ID("mci_clk", "atmel_mci1", &mmc1_clk),
>   	CLKDEV_CON_DEV_ID("spi_clk", "atmel_spi0", &spi0_clk),
>   	CLKDEV_CON_DEV_ID("spi_clk", "atmel_spi1", &spi1_clk),
> +	CLKDEV_CON_DEV_ID(NULL, "at91-twi0", &twi0_clk),

s/CLKDEV_CON_DEV_ID/CLKDEV_DEV_ID (also for the following).

the DEV_ID should be presented in the id_table in the driver.

> +	CLKDEV_CON_DEV_ID(NULL, "at91-twi1", &twi1_clk),
> +	CLKDEV_CON_DEV_ID(NULL, "fff84000.i2c", &twi0_clk),
> +	CLKDEV_CON_DEV_ID(NULL, "fff88000.i2c", &twi1_clk),
>   	CLKDEV_DEV_ID("at91rm9200-gpio0", &pioA_clk),
>   	CLKDEV_DEV_ID("at91rm9200-gpio1", &pioB_clk),
>   	CLKDEV_DEV_ID("at91rm9200-gpio2", &pioC_clk),
>

Best Regards,
Bo Shen

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2014-08-04  9:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-04  8:31 [PATCH V2 0/2] Add device tree support of i2c Atmel driver Raphaël Poggi
2014-08-04  8:31 ` [PATCH V2 1/2] i2c: at91: add support of device tree Raphaël Poggi
2014-08-04  9:14   ` Bo Shen
2014-08-04  9:42     ` Raphaël Poggi
2014-08-04  9:50       ` Bo Shen
2014-08-04  8:31 ` [PATCH V2 2/2] at91sam9g45: clock: add i2c clocks Raphaël Poggi
2014-08-04  9:17   ` Bo Shen [this message]
2014-08-04  9:28     ` Raphaël Poggi
2014-08-04  9:11 ` [PATCH V2 0/2] Add device tree support of i2c Atmel driver Bo Shen
2014-08-04  9:22   ` Raphaël Poggi
2014-08-04  9:29     ` Bo Shen
2014-08-05  6:55       ` Bo Shen
2014-08-05  8:32         ` Raphaël Poggi
2014-08-05 20:05           ` Raphaël Poggi
2014-08-06  1:06             ` Bo Shen
2014-08-06  7:16               ` Raphaël Poggi
2014-08-06  7:33                 ` Bo Shen
2014-08-06  7:40                   ` Raphaël Poggi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53DF4F9E.2070901@atmel.com \
    --to=voice.shen@atmel.com \
    --cc=barebox@lists.infradead.org \
    --cc=poggi.raph@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.