Re: [PATCH v10 08/12] tools/libxl: parse optional start gfn from the iomem config option

[Julien Grall <julien.grall@linaro.org>]

Hi Arianna,

On 07/28/2014 11:12 PM, Arianna Avanzini wrote:
> diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
> index 0686f96..3bfe65b 100644
> --- a/tools/libxl/libxl_create.c
> +++ b/tools/libxl/libxl_create.c
> @@ -102,6 +102,8 @@ static int sched_params_valid(libxl__gc *gc,
>  int libxl__domain_build_info_setdefault(libxl__gc *gc,
>                                          libxl_domain_build_info *b_info)
>  {
> +    int i;
> +

I've tried to build this series and get the following error in libxl:

libxl_create.c: In function ‘libxl__domain_build_info_setdefault’:
libxl_create.c:195:13: error: declaration of ‘i’ shadows a previous local [-Werror=shadow]
         int i;
             ^
libxl_create.c:106:9: error: shadowed declaration is here [-Werror=shadow]
     int i;
         ^
cc1: all warnings being treated as errors

I think you have to drop the variable i defined around line 195.

Regards,

-- 
Julien Grall