From: Eric Sandeen <sandeen@sandeen.net>
To: Omer Caspi <omer.caspi@plexistor.com>, fstests@vger.kernel.org
Cc: Boaz <boaz@plexistor.com>
Subject: Re: generic/076 cleanup
Date: Mon, 04 Aug 2014 10:12:13 -0500 [thread overview]
Message-ID: <53DFA2CD.8010101@sandeen.net> (raw)
In-Reply-To: <53DF6C3F.6010406@plexistor.com>
On 8/4/14, 6:19 AM, Omer Caspi wrote:
> While running some tests from the xfstests suite (quick group), I noticed
> that generic test 076 doesn't clean after itself. Specifically, a couple
> of directories (p1 and p2) remain on $TEST_DIR once the test is completed.
> To my understanding, a test should cleanup the files it had created, so I
> added a rm command to test's _cleanup function to fix it, which seems to
> be OK, but I thought I'll check: is there a reason for these directories
> to remain there after the test completion?
>
> Omer
the test device is supposed to age, so leaving things lying around there
after the test has run is expected, and fine.
_cleanup is more about removing tmpfiles, killing any spawned threads,
etc - not about cleaning up the test device.
-Eric
prev parent reply other threads:[~2014-08-04 15:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 11:19 generic/076 cleanup Omer Caspi
2014-08-04 15:12 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DFA2CD.8010101@sandeen.net \
--to=sandeen@sandeen.net \
--cc=boaz@plexistor.com \
--cc=fstests@vger.kernel.org \
--cc=omer.caspi@plexistor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.