From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH v6 10/10] ARM: dts: Add exynos5250-spring device tree Date: Mon, 04 Aug 2014 19:31:12 +0200 Message-ID: <53DFC360.9080304@collabora.co.uk> References: <1406940750-15880-1-git-send-email-afaerber@suse.de> <1406940750-15880-11-git-send-email-afaerber@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from bhuna.collabora.co.uk ([93.93.135.160]:33736 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750892AbaHDRbU (ORCPT ); Mon, 4 Aug 2014 13:31:20 -0400 In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Doug Anderson , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: linux-samsung-soc , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Stephan van Schaik , Vincent Palatin , Tomasz Figa , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Ben Dooks , Kukjin Kim , open list , Julius Werner Hello Doug, On 08/04/2014 05:22 PM, Doug Anderson wrote: >> + >> +&pinctrl_0 { >> + s5m8767_dvs: s5m8767-dvs { >> + samsung,pins = "gpd1-0", "gpd1-1", "gpd1-2"; >> + samsung,pin-function = <0>; >> + samsung,pin-pud = <1>; >> + samsung,pin-drv = <0>; >> + }; >> + >> + dp_hpd_gpio: dp-hpd-gpio { >> + samsung,pins = "gpc3-0"; >> + samsung,pin-function = <0>; >> + samsung,pin-pud = <3>; >> + samsung,pin-drv = <0>; >> + }; >> + >> + power_key_irq: power-key-irq { >> + samsung,pins = "gpx1-3"; >> + samsung,pin-function = <0>; >> + samsung,pin-pud = <0>; >> + samsung,pin-drv = <0>; >> + }; > > The fact that snow is missing the pinctrl lines for power and lid is a > bug on snow. Perhaps Javier would be interested in submitting a patch > to fix that? > > Sure, added on my TODO list to not only add these missing pin control lines for lid and power and reference them on gpio-keys but also to double check if there is anything else missing in the mainline Snow DTS that is on the downstream Chrome OS one. I'll wait for Andreas series to be picked by Kukjin before submit a patch though to avoid any unnecessary churn. Best regards, Javier From mboxrd@z Thu Jan 1 00:00:00 1970 From: javier.martinez@collabora.co.uk (Javier Martinez Canillas) Date: Mon, 04 Aug 2014 19:31:12 +0200 Subject: [PATCH v6 10/10] ARM: dts: Add exynos5250-spring device tree In-Reply-To: References: <1406940750-15880-1-git-send-email-afaerber@suse.de> <1406940750-15880-11-git-send-email-afaerber@suse.de> Message-ID: <53DFC360.9080304@collabora.co.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Doug, On 08/04/2014 05:22 PM, Doug Anderson wrote: >> + >> +&pinctrl_0 { >> + s5m8767_dvs: s5m8767-dvs { >> + samsung,pins = "gpd1-0", "gpd1-1", "gpd1-2"; >> + samsung,pin-function = <0>; >> + samsung,pin-pud = <1>; >> + samsung,pin-drv = <0>; >> + }; >> + >> + dp_hpd_gpio: dp-hpd-gpio { >> + samsung,pins = "gpc3-0"; >> + samsung,pin-function = <0>; >> + samsung,pin-pud = <3>; >> + samsung,pin-drv = <0>; >> + }; >> + >> + power_key_irq: power-key-irq { >> + samsung,pins = "gpx1-3"; >> + samsung,pin-function = <0>; >> + samsung,pin-pud = <0>; >> + samsung,pin-drv = <0>; >> + }; > > The fact that snow is missing the pinctrl lines for power and lid is a > bug on snow. Perhaps Javier would be interested in submitting a patch > to fix that? > > Sure, added on my TODO list to not only add these missing pin control lines for lid and power and reference them on gpio-keys but also to double check if there is anything else missing in the mainline Snow DTS that is on the downstream Chrome OS one. I'll wait for Andreas series to be picked by Kukjin before submit a patch though to avoid any unnecessary churn. Best regards, Javier