From: "H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
To: Matt Fleming <matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
Cc: Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Matt Fleming
<matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Borislav Petkov <bp-l3A5Bk7waGM@public.gmane.org>,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
Subject: Re: [PATCH] x86/efi: Fix 3DNow optimization build failure in EFI stub
Date: Mon, 04 Aug 2014 16:06:01 -0700 [thread overview]
Message-ID: <53E011D9.5040908@zytor.com> (raw)
In-Reply-To: <1407192735-26368-1-git-send-email-matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
On 08/04/2014 03:52 PM, Matt Fleming wrote:
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 801ed36c2e49..fcad2e15e92a 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1520,7 +1520,7 @@ config X86_SMAP
>
> config EFI
> bool "EFI runtime service support"
> - depends on ACPI
> + depends on ACPI && !X86_USE_3DNOW
> select UCS2_STRING
> select EFI_RUNTIME_WRAPPERS
> ---help---
>
As we discussed over IRC, should be EFI_STUB not EFI. Once that is fixed:
Acked-by: H. Peter Anvin <hpa-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
... in case Ingo or Thomas grabs it before I do.
-hpa
WARNING: multiple messages have this Message-ID (diff)
From: "H. Peter Anvin" <hpa@zytor.com>
To: Matt Fleming <matt@console-pimps.org>
Cc: Ingo Molnar <mingo@kernel.org>,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
Matt Fleming <matt.fleming@intel.com>,
Borislav Petkov <bp@suse.de>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86/efi: Fix 3DNow optimization build failure in EFI stub
Date: Mon, 04 Aug 2014 16:06:01 -0700 [thread overview]
Message-ID: <53E011D9.5040908@zytor.com> (raw)
In-Reply-To: <1407192735-26368-1-git-send-email-matt@console-pimps.org>
On 08/04/2014 03:52 PM, Matt Fleming wrote:
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 801ed36c2e49..fcad2e15e92a 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1520,7 +1520,7 @@ config X86_SMAP
>
> config EFI
> bool "EFI runtime service support"
> - depends on ACPI
> + depends on ACPI && !X86_USE_3DNOW
> select UCS2_STRING
> select EFI_RUNTIME_WRAPPERS
> ---help---
>
As we discussed over IRC, should be EFI_STUB not EFI. Once that is fixed:
Acked-by: H. Peter Anvin <hpa@linux.intel.com>
... in case Ingo or Thomas grabs it before I do.
-hpa
next prev parent reply other threads:[~2014-08-04 23:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 22:52 [PATCH] x86/efi: Fix 3DNow optimization build failure in EFI stub Matt Fleming
[not found] ` <1407192735-26368-1-git-send-email-matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-08-04 23:06 ` H. Peter Anvin [this message]
2014-08-04 23:06 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E011D9.5040908@zytor.com \
--to=hpa-ymnouzjc4hwavxtiumwx3w@public.gmane.org \
--cc=bp-l3A5Bk7waGM@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org \
--cc=matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.