From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [PATCH] x86/efi: Fix 3DNow optimization build failure in EFI stub Date: Mon, 04 Aug 2014 16:06:01 -0700 Message-ID: <53E011D9.5040908@zytor.com> References: <1407192735-26368-1-git-send-email-matt@console-pimps.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1407192735-26368-1-git-send-email-matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Matt Fleming Cc: Ingo Molnar , linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Matt Fleming , Borislav Petkov , Thomas Gleixner List-Id: linux-efi@vger.kernel.org On 08/04/2014 03:52 PM, Matt Fleming wrote: > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 801ed36c2e49..fcad2e15e92a 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -1520,7 +1520,7 @@ config X86_SMAP > > config EFI > bool "EFI runtime service support" > - depends on ACPI > + depends on ACPI && !X86_USE_3DNOW > select UCS2_STRING > select EFI_RUNTIME_WRAPPERS > ---help--- > As we discussed over IRC, should be EFI_STUB not EFI. Once that is fixed: Acked-by: H. Peter Anvin ... in case Ingo or Thomas grabs it before I do. -hpa From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753284AbaHDXGi (ORCPT ); Mon, 4 Aug 2014 19:06:38 -0400 Received: from terminus.zytor.com ([198.137.202.10]:56229 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752730AbaHDXGh (ORCPT ); Mon, 4 Aug 2014 19:06:37 -0400 Message-ID: <53E011D9.5040908@zytor.com> Date: Mon, 04 Aug 2014 16:06:01 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: Matt Fleming CC: Ingo Molnar , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Matt Fleming , Borislav Petkov , Thomas Gleixner Subject: Re: [PATCH] x86/efi: Fix 3DNow optimization build failure in EFI stub References: <1407192735-26368-1-git-send-email-matt@console-pimps.org> In-Reply-To: <1407192735-26368-1-git-send-email-matt@console-pimps.org> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/04/2014 03:52 PM, Matt Fleming wrote: > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 801ed36c2e49..fcad2e15e92a 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -1520,7 +1520,7 @@ config X86_SMAP > > config EFI > bool "EFI runtime service support" > - depends on ACPI > + depends on ACPI && !X86_USE_3DNOW > select UCS2_STRING > select EFI_RUNTIME_WRAPPERS > ---help--- > As we discussed over IRC, should be EFI_STUB not EFI. Once that is fixed: Acked-by: H. Peter Anvin ... in case Ingo or Thomas grabs it before I do. -hpa