From mboxrd@z Thu Jan 1 00:00:00 1970 From: Razvan Cojocaru Subject: Re: [PATCH RFC V4 4/5] xen, libxc: Request page fault injection via libxc Date: Tue, 05 Aug 2014 12:59:54 +0300 Message-ID: <53E0AB1A.4020603@bitdefender.com> References: <1407151825-3843-1-git-send-email-rcojocaru@bitdefender.com> <1407151825-3843-4-git-send-email-rcojocaru@bitdefender.com> <53DFB4270200007800029147@mail.emea.novell.com> <53DFA022.9000100@bitdefender.com> <53DFC0D30200007800029228@mail.emea.novell.com> <53E0913B.2070309@bitdefender.com> <53E0B46A0200007800029561@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53E0B46A0200007800029561@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: kevin.tian@intel.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, eddie.dong@intel.com, xen-devel@lists.xen.org, jun.nakajima@intel.com, ian.jackson@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 08/05/2014 11:39 AM, Jan Beulich wrote: > #define INTR_INFO_VECTOR_MASK 0xff /* 7:0 */ > #define INTR_INFO_INTR_TYPE_MASK 0x700 /* 10:8 */ > > i.e. all you need is there, you just need to make use of them > (and please also - perhaps in an initial cleanup patch - for the > original you cloned from). And just to avoid a needless further > intermediate round: While there is no #define for the shift count > used, you also don't need one if you make use of MASK_EXTR(). Cleanup patch submitted: http://lists.xen.org/archives/html/xen-devel/2014-08/msg00439.html Thanks, Razvan Cojocaru