All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jindal, Sonika" <sonika.jindal@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/6] drm: Renaming DP training vswing/pre-emph defines
Date: Tue, 05 Aug 2014 17:03:56 +0530	[thread overview]
Message-ID: <53E0C124.7080907@intel.com> (raw)
In-Reply-To: <20140805111535.GH8727@phenom.ffwll.local>



On 8/5/2014 4:45 PM, Daniel Vetter wrote:
> On Tue, Aug 05, 2014 at 04:38:17PM +0530, sonika.jindal@intel.com wrote:
>> From: Sonika Jindal <sonika.jindal@intel.com>
>>
>> Renaming defines to have levels instead of nominal values.
>>
>> Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
>
> You can't split up patches like this since this will break compilation.
> For larger stuff (and imo this is right above the cutoff) you first need
> to add the new functions/defines, then convert everyone over. And only
> when all the drivers are converted can we apply the patch to remove the
> old functions/defines.
> -Daniel
>
Got your concern. So, I will repost the first patch keeping both the 
defines and an additional last patch for removing the extra defines.
>> ---
>>   include/drm/drm_dp_helper.h |   16 ++++++++--------
>>   1 file changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
>> index a21568b..70f362b 100644
>> --- a/include/drm/drm_dp_helper.h
>> +++ b/include/drm/drm_dp_helper.h
>> @@ -190,16 +190,16 @@
>>   # define DP_TRAIN_VOLTAGE_SWING_MASK	    0x3
>>   # define DP_TRAIN_VOLTAGE_SWING_SHIFT	    0
>>   # define DP_TRAIN_MAX_SWING_REACHED	    (1 << 2)
>> -# define DP_TRAIN_VOLTAGE_SWING_400	    (0 << 0)
>> -# define DP_TRAIN_VOLTAGE_SWING_600	    (1 << 0)
>> -# define DP_TRAIN_VOLTAGE_SWING_800	    (2 << 0)
>> -# define DP_TRAIN_VOLTAGE_SWING_1200	    (3 << 0)
>> +# define DP_TRAIN_VOLTAGE_SWING_LEVEL_0     (0 << 0)
>> +# define DP_TRAIN_VOLTAGE_SWING_LEVEL_1     (1 << 0)
>> +# define DP_TRAIN_VOLTAGE_SWING_LEVEL_2     (2 << 0)
>> +# define DP_TRAIN_VOLTAGE_SWING_LEVEL_3     (3 << 0)
>>
>>   # define DP_TRAIN_PRE_EMPHASIS_MASK	    (3 << 3)
>> -# define DP_TRAIN_PRE_EMPHASIS_0	    (0 << 3)
>> -# define DP_TRAIN_PRE_EMPHASIS_3_5	    (1 << 3)
>> -# define DP_TRAIN_PRE_EMPHASIS_6	    (2 << 3)
>> -# define DP_TRAIN_PRE_EMPHASIS_9_5	    (3 << 3)
>> +# define DP_TRAIN_PRE_EMPHASIS_LEVEL_0  (0 << 3)
>> +# define DP_TRAIN_PRE_EMPHASIS_LEVEL_1  (1 << 3)
>> +# define DP_TRAIN_PRE_EMPHASIS_LEVEL_2  (2 << 3)
>> +# define DP_TRAIN_PRE_EMPHASIS_LEVEL_3  (3 << 3)
>>
>>   # define DP_TRAIN_PRE_EMPHASIS_SHIFT	    3
>>   # define DP_TRAIN_MAX_PRE_EMPHASIS_REACHED  (1 << 5)
>> --
>> 1.7.10.4
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>

  reply	other threads:[~2014-08-05 11:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-05 11:08 [PATCH 0/6] Rename DP training vswing/pre-emph defines sonika.jindal
2014-08-05 11:08 ` [PATCH 1/6] drm: Renaming " sonika.jindal
2014-08-05 11:15   ` Daniel Vetter
2014-08-05 11:33     ` Jindal, Sonika [this message]
2014-08-05 12:30       ` Daniel Vetter
2014-08-06  5:31         ` Jindal, Sonika
2014-08-05 11:44     ` [PATCH] " sonika.jindal
2014-08-05 11:44       ` [PATCH] drm: Removing the redundant " sonika.jindal
2014-08-06 11:18       ` [PATCH] drm: Renaming DP training " sonika.jindal
2014-08-06  2:01   ` [PATCH 1/6] " Jingoo Han
2014-08-05 11:08 ` [PATCH 2/6] drm/i915: " sonika.jindal
2014-08-05 11:47   ` [PATCH] " sonika.jindal
2014-08-05 11:08 ` [PATCH 3/6] drm/exynos: " sonika.jindal
2014-08-05 11:08 ` [PATCH 4/6] drm/radeon: " sonika.jindal
2014-08-05 11:08 ` [PATCH 5/6] drm/gma500: " sonika.jindal
2014-08-05 11:08 ` [PATCH 6/6] drm/tegra: " sonika.jindal
2014-08-07 10:13 ` [PATCH 0/6] Rename " Damien Lespiau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53E0C124.7080907@intel.com \
    --to=sonika.jindal@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.