From mboxrd@z Thu Jan  1 00:00:00 1970
From: Razvan Cojocaru <rcojocaru@bitdefender.com>
Subject: Re: [PATCH] xen: Use #defines instead of magic
 constants in vmx_vmcs_save()
Date: Tue, 05 Aug 2014 15:26:48 +0300
Message-ID: <53E0CD88.30903@bitdefender.com>
References: <1407232657-29156-1-git-send-email-rcojocaru@bitdefender.com>
	<53E0E47C0200007800029706@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <53E0E47C0200007800029706@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: eddie.dong@intel.com, kevin.tian@intel.com, keir@xen.org, jun.nakajima@intel.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 08/05/2014 03:04 PM, Jan Beulich wrote:
>>>> On 05.08.14 at 11:57, <rcojocaru@bitdefender.com> wrote:
>> --- a/xen/arch/x86/hvm/vmx/vmx.c
>> +++ b/xen/arch/x86/hvm/vmx/vmx.c
>> @@ -434,7 +434,8 @@ static void vmx_vmcs_save(struct vcpu *v, struct hvm_hw_cpu *c)
>>      c->error_code = 0;
>>      __vmread(VM_ENTRY_INTR_INFO, &ev);
>>      if ( (ev & INTR_INFO_VALID_MASK) &&
>> -         hvm_event_needs_reinjection((ev >> 8) & 7, ev & 0xff) )
>> +         hvm_event_needs_reinjection(MASK_EXTR(ev, INTR_INFO_INTR_TYPE_MASK),
>> +            ev & INTR_INFO_VECTOR_MASK) )
> 
> Broken indentation, but I guess I can fix this up while committing
> unless the VMX maintainers dislike the change and don't give their
> ack.

No worries, I've sent V2:

http://lists.xen.org/archives/html/xen-devel/2014-08/msg00471.html

Hope it's right this time.


Thanks,
Razvan Cojocaru