From: Julien Grall <julien.grall@linaro.org>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
xen-devel@lists.xensource.com
Cc: julien.grall@citrix.com, Ian.Campbell@citrix.com
Subject: Re: [PATCH v10 07/10] xen: remove workaround to inject evtchn_irq on irq enable
Date: Tue, 05 Aug 2014 13:34:31 +0100 [thread overview]
Message-ID: <53E0CF57.40201@linaro.org> (raw)
In-Reply-To: <1407237989-27654-7-git-send-email-stefano.stabellini@eu.citrix.com>
Hi Stefano,
On 08/05/2014 12:26 PM, Stefano Stabellini wrote:
> evtchn_upcall_pending is already set by common code at vcpu creation,
> therefore on ARM we also need to call vgic_vcpu_inject_irq for it.
> Currently we do that from vgic_enable_irqs as a workaround.
>
> Do this properly by introducing an appropriate arch specific hook:
> arch_evtchn_inject. arch_evtchn_inject is called by map_vcpu_info to
> inject the evtchn irq into the guest. On ARM is implemented by calling
> vgic_vcpu_inject_irq.
>
> On x86 guests typically don't call VCPUOP_register_vcpu_info on vcpu0,
> therefore avoiding the issue. However theoretically they could call
> VCPUOP_register_vcpu_info on vcpu0 and in that case Xen would need to
> inject the event channel notification into the guest if the guest is
> HVM. So implement arch_evtchn_inject on x86 by calling
> hvm_assert_evtchn_irq.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Acked-by: Julien Grall <julien.grall@linaro.org>
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-08-05 12:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 11:25 [PATCH v10 00/10] gic and vgic fixes and improvements Stefano Stabellini
2014-08-05 11:26 ` [PATCH v10 01/10] xen/arm: observe itargets setting in vgic_enable_irqs and vgic_disable_irqs Stefano Stabellini
2014-08-05 11:26 ` [PATCH v10 02/10] xen/arm: move setting GIC_IRQ_GUEST_QUEUED earlier Stefano Stabellini
2014-08-05 11:26 ` [PATCH v10 03/10] xen/arm: inflight irqs during migration Stefano Stabellini
2014-08-05 12:28 ` Julien Grall
2014-08-05 14:35 ` Stefano Stabellini
2014-08-05 11:26 ` [PATCH v10 04/10] xen/arm: support irq delivery to vcpu > 0 Stefano Stabellini
2014-08-05 11:26 ` [PATCH v10 05/10] xen/arm: physical irq follow virtual irq Stefano Stabellini
2014-08-05 11:57 ` Jan Beulich
2014-08-05 12:01 ` Jan Beulich
2014-08-05 11:26 ` [PATCH v10 06/10] xen: introduce sched_move_irqs Stefano Stabellini
2014-08-05 11:26 ` [PATCH v10 07/10] xen: remove workaround to inject evtchn_irq on irq enable Stefano Stabellini
2014-08-05 12:00 ` Jan Beulich
2014-08-05 12:34 ` Julien Grall [this message]
2014-08-05 11:26 ` [PATCH v10 08/10] xen/arm: take the rank lock before accessing ipriority Stefano Stabellini
2014-08-05 11:26 ` [PATCH v10 09/10] xen: introduce bit access macros for the IRQ line status flags Stefano Stabellini
2014-08-05 11:26 ` [PATCH v10 10/10] xen/arm: make accesses to desc->status flags atomic Stefano Stabellini
2014-08-05 12:35 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E0CF57.40201@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=julien.grall@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.