From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55605) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEeX0-0002n9-Pw for qemu-devel@nongnu.org; Tue, 05 Aug 2014 09:12:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XEeWv-0003CE-SZ for qemu-devel@nongnu.org; Tue, 05 Aug 2014 09:11:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43892) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEeWv-0003C4-KC for qemu-devel@nongnu.org; Tue, 05 Aug 2014 09:11:53 -0400 Message-ID: <53E0D817.5020903@redhat.com> Date: Tue, 05 Aug 2014 07:11:51 -0600 From: Eric Blake MIME-Version: 1.0 References: <1406936961-20356-1-git-send-email-mreitz@redhat.com> <1406936961-20356-5-git-send-email-mreitz@redhat.com> In-Reply-To: <1406936961-20356-5-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="aRUsaCcS6jFaKbXNnev0sWnpwg3b0B0DE" Subject: Re: [Qemu-devel] [PATCH v2 4/7] block/qcow2: Implement status CB for amend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --aRUsaCcS6jFaKbXNnev0sWnpwg3b0B0DE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/01/2014 05:49 PM, Max Reitz wrote: > The only really time-consuming operation potentially performed by > qcow2_amend_options() is zero cluster expansion when downgrading qcow2 > images from compat=3D1.1 to compat=3D0.10, so report status of that > operation and that operation only through the status CB. >=20 > For this, approximate the progress as the number of L1 entries visited > during the operation. >=20 > Signed-off-by: Max Reitz > --- > block/qcow2-cluster.c | 37 +++++++++++++++++++++++++++++++++---- > block/qcow2.c | 7 ++++--- > block/qcow2.h | 3 ++- > 3 files changed, 39 insertions(+), 8 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --aRUsaCcS6jFaKbXNnev0sWnpwg3b0B0DE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT4NgXAAoJEKeha0olJ0Nq9JoH/jcryeGC+kHLFOCAvxVHY0ja H6jZv9NXbbaE3/Q6z5Fsh+8x6P+T8TjY3heXDDn8g4OIm7OZ2K0CJvxPHOToizTj Wluip2NVHahN+KjOlC1caXYpN7d4AjXBuyXfka84ctGa+6VBFQAKyn7uT0Mw3WzH 7Iydfl1vOxWxtsuIwy6zmxL4BT876cm+dGwZvdE8okTQm14qp2VD29JUdAglW0El gowQk+lvU6v2M4InhtTlK01gSGr6uhUYf2m+GFRrrJQXFeKTZ+HsvZe+TEWYi4Ez 85xKC75K1XICBd3vudRNTdq/9VpKGDOFgmMeedH4ocGXN5PXaHQoqk/n4C/pC5Q= =BdHU -----END PGP SIGNATURE----- --aRUsaCcS6jFaKbXNnev0sWnpwg3b0B0DE--